From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: restore correct batch limiting
Date: Wed, 17 Oct 2012 16:01:22 +0200 [thread overview]
Message-ID: <1350482482.26103.495.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAJd=RBD1LKiQecdrK67w+Wn=P1mMfRv6JERWUjxpAthm_p+LzA@mail.gmail.com>
On Wed, 2012-10-17 at 21:18 +0800, Hillf Danton wrote:
> > /* did other CPU force QS recently? */
> > - long blimit; /* Upper limit on a processed batch */
> > + int blimit; /* Upper limit on a processed batch */
> >
> > /* 3) dynticks interface. */
> > + int dynticks_snap; /* Per-GP tracking for dynticks. */
> > struct rcu_dynticks *dynticks; /* Shared per-CPU dynticks state. */
> > - int dynticks_snap; /* Per-GP tracking for dynticks. */
>
> Hm, no words in change log for shuffling dynticks_snap...
I dont like adding two 32bit holes on a structure ;)
This kind of trivial things dont need a changelog, especially when
fixing a critical bug.
I let Paul add this if he really wants.
next prev parent reply other threads:[~2012-10-17 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 7:14 Eric Dumazet
2012-10-17 13:18 ` Hillf Danton
2012-10-17 14:01 ` Eric Dumazet [this message]
2012-10-18 11:58 ` Paul E. McKenney
2012-10-18 12:44 ` Eric Dumazet
2012-10-18 15:25 ` Paul E. McKenney
2012-10-18 16:10 ` Eric Dumazet
2012-10-18 16:35 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350482482.26103.495.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®