mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: peterz@infradead.org, mingo@redhat.com, tglx@linutronix.de,
	devel@openvz.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] posix timers: allocate timer id per process
Date: Thu, 18 Oct 2012 10:04:30 +0200	[thread overview]
Message-ID: <1350547470.26103.1158.camel@edumazet-glaptop> (raw)
In-Reply-To: <20121018074953.14057.52370.stgit@localhost.localdomain>

On Thu, 2012-10-18 at 11:49 +0400, Stanislav Kinsbursky wrote:


> +
> +static struct k_itimer *__posix_timers_find(struct hlist_head *head, struct signal_struct *sig, timer_t id)

This line is too long

Please use scripts/checkpatch.pl

Other than that, your patch seems fine to me

Thanks



      reply	other threads:[~2012-10-18  8:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  7:49 Stanislav Kinsbursky
2012-10-18  8:04 ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350547470.26103.1158.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=skinsbursky@parallels.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®