From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755452Ab2JRKED (ORCPT ); Thu, 18 Oct 2012 06:04:03 -0400 Received: from smtp.citrix.com ([66.165.176.89]:63068 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755125Ab2JRKEA (ORCPT ); Thu, 18 Oct 2012 06:04:00 -0400 X-IronPort-AV: E=Sophos;i="4.80,606,1344211200"; d="scan'208";a="41651101" From: David Vrabel To: xen-devel@lists.xen.org CC: "David Vrabel" , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, Jens Axboe Subject: [PATCH 2/5] xen-blkfront: handle backend CLOSED without CLOSING Date: Thu, 18 Oct 2012 11:03:35 +0100 Message-ID: <1350554618-14582-2-git-send-email-david.vrabel@citrix.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <507FD39F.4060601@citrix.com> References: <507FD39F.4060601@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Vrabel Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown. So, treat an unexpected backend CLOSED state the same as CLOSING. Signed-off-by: David Vrabel Acked-by: Konrad Rzeszutek Wilk --- Cc: Jens Axboe --- drivers/block/xen-blkfront.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 007db89..5d162b5 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1340,13 +1340,16 @@ static void blkback_changed(struct xenbus_device *dev, case XenbusStateReconfiguring: case XenbusStateReconfigured: case XenbusStateUnknown: - case XenbusStateClosed: break; case XenbusStateConnected: blkfront_connect(info); break; + case XenbusStateClosed: + if (dev->state == XenbusStateClosed) + break; + /* Missed the backend's Closing state -- fallthrough */ case XenbusStateClosing: blkfront_closing(info); break; -- 1.7.2.5