From: Joe Perches <joe@perches.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH -next] printk: fix broken 'console' kernel parameter
Date: Tue, 23 Oct 2012 06:49:13 -0700 [thread overview]
Message-ID: <1351000153.7502.44.camel@joe-AO722> (raw)
In-Reply-To: <1350999678-17441-1-git-send-email-ming.lei@canonical.com>
On Tue, 2012-10-23 at 21:41 +0800, Ming Lei wrote:
> If CONFIG_A11Y_BRAILLE_CONSOLE is not enabled, _braille_console_setup()
> should return NULL to parse the parameter further in console_setup().
>
> This patch fixes the broken 'console' kernel parameter, which makes the
> Pandaboard not boot with 'console=ttyO2'.
[]
> diff --git a/kernel/printk/braille.h b/kernel/printk/braille.h
[]
> @@ -28,7 +28,7 @@ braille_set_options(struct console_cmdline *c, char *brl_options)
> static inline char *
> _braille_console_setup(char **str, char **brl_options)
> {
> - return *str;
> + return NULL;
> }
Thanks, I'll wait a day or two for any more reports
then repost the whole series.
next prev parent reply other threads:[~2012-10-23 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 13:41 Ming Lei
2012-10-23 13:49 ` Joe Perches [this message]
2012-10-23 14:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351000153.7502.44.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®