From: Joe Perches <joe@perches.com>
To: Andrey Smirnov <andrey.smirnov@convergeddevices.net>
Cc: hverkuil@xs4all.nl, mchehab@redhat.com, sameo@linux.intel.com,
broonie@opensource.wolfsonmicro.com, perex@perex.cz,
tiwai@suse.de, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] Add header files and Kbuild plumbing for SI476x MFD core
Date: Tue, 23 Oct 2012 15:56:59 -0700 [thread overview]
Message-ID: <1351033019.7502.66.camel@joe-AO722> (raw)
In-Reply-To: <1351017872-32488-2-git-send-email-andrey.smirnov@convergeddevices.net>
On Tue, 2012-10-23 at 11:44 -0700, Andrey Smirnov wrote:
> This patch adds all necessary header files and Kbuild plumbing for the
> core driver for Silicon Laboratories Si476x series of AM/FM tuner
> chips.
[]
> +#ifdef DEBUG
> +#define DBG_BUFFER(device, header, buffer, bcount) \
> + do { \
> + dev_info((device), header); \
> + print_hex_dump_bytes("", \
> + DUMP_PREFIX_OFFSET, \
> + buffer, bcount); \
> + } while (0)
maybe just:
dev_dbg(device, whatever_fmt ": %*ph\n", bcount, buffer);
at each call site
next prev parent reply other threads:[~2012-10-23 23:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 18:44 [PATCH v3 0/6] Driver for Si476x series of chips Andrey Smirnov
2012-10-23 18:44 ` [PATCH v3 1/6] Add header files and Kbuild plumbing for SI476x MFD core Andrey Smirnov
2012-10-23 22:56 ` Joe Perches [this message]
2012-10-23 18:44 ` [PATCH v3 2/6] Add the main bulk of core driver for SI476x code Andrey Smirnov
2012-10-25 19:45 ` Mark Brown
2012-10-25 22:26 ` Andrey Smirnov
2012-10-27 21:31 ` Mark Brown
2012-10-28 2:08 ` Andrey Smirnov
2012-11-16 14:35 ` Hans Verkuil
2012-10-23 18:44 ` [PATCH v3 3/6] Add commands abstraction layer for SI476X MFD Andrey Smirnov
2012-10-23 18:44 ` [PATCH v3 4/6] Add chip properties handling code " Andrey Smirnov
2012-10-23 18:44 ` [PATCH v3 5/6] Add a V4L2 driver " Andrey Smirnov
2012-11-16 15:02 ` Hans Verkuil
2012-11-23 22:04 ` Andrey Smirnov
2012-11-16 22:22 ` Alexey Klimov
2012-10-23 18:44 ` [PATCH v3 6/6] Add a codec " Andrey Smirnov
2012-10-23 19:24 ` Mark Brown
2012-10-23 20:09 ` Andrey Smirnov
2013-02-11 22:39 ` [PATCH v3 0/6] Driver for Si476x series of chips Alexey Klimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351033019.7502.66.camel@joe-AO722 \
--to=joe@perches.com \
--cc=andrey.smirnov@convergeddevices.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=perex@perex.cz \
--cc=sameo@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®