From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl
Cc: eranian@google.com, ak@linux.intel.com, "Yan,
Zheng" <zheng.z.yan@intel.com>
Subject: [PATCH V2 7/7] perf, x86: Discard zero length call entries in LBR call stack
Date: Wed, 24 Oct 2012 13:59:10 +0800 [thread overview]
Message-ID: <1351058350-9159-8-git-send-email-zheng.z.yan@intel.com> (raw)
In-Reply-To: <1351058350-9159-1-git-send-email-zheng.z.yan@intel.com>
From: "Yan, Zheng" <zheng.z.yan@intel.com>
Zero length calls may confuse the hardware and make the recorded
call stack incorrect. Try fixing the call stack by discarding
zero length call entries.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_lbr.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_lbr.c b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
index 4879904..012ddca 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_lbr.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_lbr.c
@@ -86,7 +86,8 @@ enum {
X86_BR_ABORT = 1 << 12,/* transaction abort */
X86_BR_INTX = 1 << 13,/* in transaction */
X86_BR_NOTX = 1 << 14,/* not in transaction */
- X86_BR_CALL_STACK = 1 << 15,/* call stack */
+ X86_BR_ZERO_CALL = 1 << 15,/* zero length call */
+ X86_BR_CALL_STACK = 1 << 16,/* call stack */
};
#define X86_BR_PLM (X86_BR_USER | X86_BR_KERNEL)
@@ -103,13 +104,15 @@ enum {
X86_BR_JMP |\
X86_BR_IRQ |\
X86_BR_ABORT |\
- X86_BR_IND_CALL)
+ X86_BR_IND_CALL |\
+ X86_BR_ZERO_CALL)
#define X86_BR_ALL (X86_BR_PLM | X86_BR_ANY)
#define X86_BR_ANY_CALL \
(X86_BR_CALL |\
X86_BR_IND_CALL |\
+ X86_BR_ZERO_CALL |\
X86_BR_SYSCALL |\
X86_BR_IRQ |\
X86_BR_INT)
@@ -625,6 +628,12 @@ static int branch_type(unsigned long from, unsigned long to, int abort)
ret = X86_BR_INT;
break;
case 0xe8: /* call near rel */
+ insn_get_immediate(&insn);
+ if (insn.immediate1.value == 0) {
+ /* zero length call */
+ ret = X86_BR_ZERO_CALL;
+ break;
+ }
case 0x9a: /* call far absolute */
ret = X86_BR_CALL;
break;
--
1.7.11.7
next prev parent reply other threads:[~2012-10-24 5:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 5:59 [PATCH V2 0/7] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-24 5:59 ` [PATCH V2 1/7] perf, x86: Reduce lbr_sel_map size Yan, Zheng
2012-10-24 7:28 ` Stephane Eranian
2012-10-24 7:49 ` Yan, Zheng
2012-10-24 8:15 ` Stephane Eranian
2012-10-24 8:23 ` Yan, Zheng
2012-10-24 8:37 ` Yan, Zheng
2012-10-24 8:53 ` Stephane Eranian
2012-10-24 5:59 ` [PATCH V2 2/7] perf, x86: Basic Haswell LBR call stack support Yan, Zheng
2012-10-24 5:59 ` [PATCH V2 3/7] perf, x86: Introduce x86 special perf event context Yan, Zheng
2012-10-24 5:59 ` [PATCH V2 4/7] perf, x86: Save/resotre LBR stack during context switch Yan, Zheng
2012-10-24 5:59 ` [PATCH V2 5/7] perf, core: Pass perf_sample_data to perf_callchain() Yan, Zheng
2012-10-24 5:59 ` [PATCH V2 6/7] perf, x86: Use LBR call stack to get user callchain Yan, Zheng
2012-10-24 8:57 ` Stephane Eranian
2012-10-24 11:23 ` Yan, Zheng
2012-10-24 11:47 ` Stephane Eranian
2012-10-24 11:52 ` Yan, Zheng
2012-10-24 12:11 ` Stephane Eranian
2012-10-24 12:21 ` Stephane Eranian
2012-10-24 12:31 ` Andi Kleen
2012-10-24 12:36 ` Stephane Eranian
2012-10-24 12:41 ` Andi Kleen
2012-10-24 12:46 ` Yan, Zheng
2012-10-24 5:59 ` Yan, Zheng [this message]
2012-10-25 9:12 ` [PATCH V2 7/7] perf, x86: Discard zero length call entries in LBR call stack Namhyung Kim
2012-10-24 8:49 ` [PATCH V2 0/7] perf, x86: Haswell LBR call stack support Stephane Eranian
2013-07-01 7:23 [PATCH v2 " Yan, Zheng
2013-07-01 7:23 ` [PATCH v2 7/7] perf, x86: Discard zero length call entries in LBR call stack Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351058350-9159-8-git-send-email-zheng.z.yan@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®