From: Vinod Koul <vkoul@infradead.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: vinod.koul@intel.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver
Date: Wed, 24 Oct 2012 16:43:38 +0530 [thread overview]
Message-ID: <1351077218.5263.62.camel@vkoul-udesk3> (raw)
In-Reply-To: <CAKohpo=t_uV-S+cbeDFvSDLe0SxXVx6tvA8yGMF45-YvU_FRvw@mail.gmail.com>
On Mon, 2012-10-08 at 18:57 +0530, Viresh Kumar wrote:
> I agree that there are some parts of your approach which might be having
> few advantages. But it is actually adding more complexity without much
> need of it. Logically speaking, we never had two devices for the same
> dma controller. We are adding them just to have pci over platform.. Which
> would mean the system become more and more complex..
>
> So, during run time...
> - there will be two device-driver binding loops.. Once for pci and then for
> platform
> - In suspend/resume... two devices will get into suspend, instead of one..
> - There might be other frameworks in kernel.. which react on struct device
> basis... they will get affected too..
> - You have larger image size for pci case. as you compile platform too..
>
> Just try to think from this perspective... we dont have two hardware devices
> in the system.... Ideally speaking there must be a struct device associated
> with a hardware device...
>
> @Arnd/Vinod: Can you guys throw some more light here.. on the adv/disadv
> of both the approaches?
I am worried about those tow. Runtime PM handlers in case PCI devices
make life a lot easier am not sure what support will be there for
platform devices in other systems.
Also next version of this h/w on our systems is bringing subtle changes
so having them separate seemed to me a better idea.
--
Vinod Koul
Intel Corp.
next prev parent reply other threads:[~2012-10-24 11:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 7:31 [PATCHv3 0/7] dw_dmac: split the driver and introduce PCI part Andy Shevchenko
2012-09-27 7:31 ` [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver() Andy Shevchenko
2012-09-27 7:40 ` Felipe Balbi
2012-09-27 8:16 ` viresh kumar
2012-09-27 8:16 ` Felipe Balbi
2012-10-01 10:47 ` Andy Shevchenko
2012-10-01 13:05 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 2/7] dmaengine: dw_dmac: add module alias Andy Shevchenko
2012-09-27 8:16 ` viresh kumar
2012-09-27 8:16 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency Andy Shevchenko
2012-09-27 7:42 ` Felipe Balbi
2012-09-27 8:04 ` Andy Shevchenko
2012-09-27 8:02 ` Felipe Balbi
2012-09-27 8:17 ` viresh kumar
2012-09-27 8:17 ` Felipe Balbi
2012-09-27 7:31 ` [PATCHv3 4/7] dmaengine: dw_dmac: amend description and indentation Andy Shevchenko
2012-09-27 7:45 ` Felipe Balbi
2012-09-27 8:19 ` viresh kumar
2012-09-27 8:36 ` Andy Shevchenko
2012-09-27 7:31 ` [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver Andy Shevchenko
2012-09-27 7:49 ` Felipe Balbi
2012-09-27 8:08 ` Andy Shevchenko
2012-09-27 8:09 ` Felipe Balbi
2012-09-27 8:44 ` Vinod Koul
2012-09-27 9:43 ` Andy Shevchenko
2012-09-27 10:01 ` Vinod Koul
2012-09-27 10:11 ` viresh kumar
2012-09-27 10:32 ` Vinod Koul
2012-10-03 13:40 ` Andy Shevchenko
2012-10-08 10:17 ` Andy Shevchenko
2012-10-08 10:49 ` Viresh Kumar
2012-10-08 12:46 ` Andy Shevchenko
2012-10-08 13:27 ` Viresh Kumar
2012-10-24 11:13 ` Vinod Koul [this message]
2012-10-30 15:05 ` Andy Shevchenko
2012-10-30 15:19 ` Viresh Kumar
2012-10-30 15:39 ` Andy Shevchenko
2012-09-27 7:32 ` [PATCHv3 6/7] dma: move dw_dmac driver to an own directory Andy Shevchenko
2012-09-27 7:50 ` Felipe Balbi
2012-09-27 8:22 ` viresh kumar
2012-09-27 8:39 ` Felipe Balbi
2012-09-27 7:32 ` [PATCHv3 7/7] MAINTAINERS: add recently created files to dw_dmac section Andy Shevchenko
2012-09-27 7:51 ` Felipe Balbi
2012-09-27 8:12 ` viresh kumar
2012-09-27 8:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351077218.5263.62.camel@vkoul-udesk3 \
--to=vkoul@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd.bergmann@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®