From: Jonas Bonn <jonas@southpole.se>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] openrisc: move sys_clone's stack determination to copy_thread
Date: Thu, 25 Oct 2012 18:16:18 +0200 [thread overview]
Message-ID: <1351181778.6232.71.camel@jerome.southpole.se> (raw)
In-Reply-To: <20121025155516.GL2616@ZenIV.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Thu, 2012-10-25 at 16:55 +0100, Al Viro wrote:
> On Thu, Oct 25, 2012 at 05:46:38PM +0200, Jonas Bonn wrote:
> > + else
> > + userregs->sp = regs->sp; /* fork/clone */
>
> What for? userregs->sp will be equal to regs->sp at that point, unless
> your compiler is very badly broken. You've copied *regs to *userregs
> wholesale, just above that if...
So true... that makes it even simpler. Will resend.
/Jonas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-25 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 15:46 [PATCH 0/2] openrisc: more kernel_thread cleanup Jonas Bonn
2012-10-25 15:46 ` [PATCH 1/2] openrisc: move sys_clone's stack determination to copy_thread Jonas Bonn
2012-10-25 15:55 ` Al Viro
2012-10-25 16:16 ` Jonas Bonn [this message]
2012-10-25 15:46 ` [PATCH 2/2] openrisc: determine regs directly in copy_thread Jonas Bonn
2012-10-25 16:27 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351181778.6232.71.camel@jerome.southpole.se \
--to=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®