From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aic7xxx_old: silence GCC warnings
Date: Mon, 29 Oct 2012 12:17:06 +0000 [thread overview]
Message-ID: <1351513026.2480.4.camel@dabdike.sthat4.btopenzone.com> (raw)
In-Reply-To: <1351506978.1339.8.camel@x61.thuisdomein>
On Mon, 2012-10-29 at 11:36 +0100, Paul Bolle wrote:
> On Fri, 2012-09-21 at 11:28 +0200, Paul Bolle wrote:
> > Building the aic7xxx_old driver triggers these GCC warnings:
> > drivers/scsi/aic7xxx_old.c:7901:5: warning: case value '257' not in enumerated type 'ahc_chip' [-Wswitch]
> > drivers/scsi/aic7xxx_old.c:7898:5: warning: case value '513' not in enumerated type 'ahc_chip' [-Wswitch]
> > drivers/scsi/aic7xxx_old.c:8517:5: warning: case value '257' not in enumerated type 'ahc_chip' [-Wswitch]
> > drivers/scsi/aic7xxx_old.c:8510:5: warning: case value '513' not in enumerated type 'ahc_chip' [-Wswitch]
> >
> > Fix these warnings by adopting the idiom used elsewhere in this driver.
> > Since AHC_EISA and AHC_VL are only ever set for AHC_AIC7770 this fix
> > should not lead to any functional change.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) I noticed these warnings while building v3.6-rc6 on current Fedora
> > 17, using Fedora's default config.
>
> Identical warnings can be seen while building v3.7-rc3. What's the
> status of my patch? Did anyone found some time to have a look at it?
the aic7xxx_old driver is in deep maintenance; I don't think anyone can
actually test changes to it anymore, so we just keep it around unchanged
for the odd really old card that can't be driven by the current driver.
For this reason, we tend only to do tested bug fixes to it because
no-one will notice if any error is introduced.
mvsas has a maintainer: poke them harder and aic94xx is currently
maintainerless, so it will depend on someone finding the time to test.
James
next prev parent reply other threads:[~2012-10-29 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 9:28 Paul Bolle
2012-10-29 10:36 ` Paul Bolle
2012-10-29 12:17 ` James Bottomley [this message]
2012-10-29 12:45 ` Paul Bolle
2013-01-29 10:05 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351513026.2480.4.camel@dabdike.sthat4.btopenzone.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®