mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: anish kumar <anish198519851985@gmail.com>
To: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
	peterz@infradead.org, akpm@linux-foundation.org,
	paul.gortmaker@windriver.com, tglx@linutronix.de,
	mingo@kernel.org, fweisbec@gmail.com
Cc: anish kumar <anish198519851985@gmail.com>
Subject: [PATCH] [RFC]IRQ CORE: irq_work_queue function return value not used.
Date: Wed, 31 Oct 2012 23:02:06 +0900	[thread overview]
Message-ID: <1351692126-8944-1-git-send-email-anish198519851985@gmail.com> (raw)

From: anish kumar <anish198519851985@gmail.com>

As no one is using the return value of irq_work_queue function
it is better to just make it void.

This patch is just a way to understand if there is some future
plan to use it but in any case please let me know the reason.
---
 kernel/irq_work.c |   21 ++++++++++-----------
 1 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 1588e3b..4a9a44c 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -32,21 +32,21 @@ static DEFINE_PER_CPU(struct llist_head, irq_work_list);
 /*
  * Claim the entry so that no one else will poke at it.
  */
-static bool irq_work_claim(struct irq_work *work)
+static void irq_work_claim(struct irq_work *work)
 {
 	unsigned long flags, nflags;
 
 	for (;;) {
 		flags = work->flags;
 		if (flags & IRQ_WORK_PENDING)
-			return false;
+			return;
 		nflags = flags | IRQ_WORK_FLAGS;
 		if (cmpxchg(&work->flags, flags, nflags) == flags)
 			break;
 		cpu_relax();
 	}
 
-	return true;
+	return;
 }
 
 void __weak arch_irq_work_raise(void)
@@ -79,15 +79,14 @@ static void __irq_work_queue(struct irq_work *work)
  *
  * Can be re-enqueued while the callback is still in progress.
  */
-bool irq_work_queue(struct irq_work *work)
+void irq_work_queue(struct irq_work *work)
 {
-	if (!irq_work_claim(work)) {
-		/*
-		 * Already enqueued, can't do!
-		 */
-		return false;
-	}
-
+	/*
+	 * This function either will claim the entry to queue
+	 * the work or if the work is already queued and is in
+	 * pending state then it will simply return.
+	 */
+	irq_work_claim(work)
 	__irq_work_queue(work);
 	return true;
 }
-- 
1.7.1


             reply	other threads:[~2012-10-31 14:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 14:02 anish kumar [this message]
2012-10-31 14:09 ` Pallala, Ramakrishna
2012-10-31 14:15 ` Steven Rostedt
2012-10-31 14:36   ` anish kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351692126-8944-1-git-send-email-anish198519851985@gmail.com \
    --to=anish198519851985@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®