From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6D0C76190 for ; Fri, 26 Jul 2019 00:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2301217D4 for ; Fri, 26 Jul 2019 00:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="IDXO3pAX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbfGZAgL (ORCPT ); Thu, 25 Jul 2019 20:36:11 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:11036 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfGZAgL (ORCPT ); Thu, 25 Jul 2019 20:36:11 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 25 Jul 2019 17:36:08 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 25 Jul 2019 17:36:10 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 25 Jul 2019 17:36:10 -0700 Received: from [10.110.48.28] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul 2019 00:36:10 +0000 Subject: Re: [PATCH 1/1] x86/boot: clear some fields explicitly To: Thomas Gleixner , "H. Peter Anvin" CC: Ingo Molnar , Borislav Petkov , , LKML References: <20190724231528.32381-1-jhubbard@nvidia.com> <20190724231528.32381-2-jhubbard@nvidia.com> <345add60-de4a-73b1-0445-127738c268b4@nvidia.com> <3DFA2707-89A6-4DD2-8DFB-0C2D1ABA1B3C@zytor.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: <1351c8ea-381c-e221-f719-2cc3abd76026@nvidia.com> Date: Thu, 25 Jul 2019 17:36:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1564101368; bh=4URRZ2WPRiKZuIY9Jax294B2lhfG9p+jCFJ353gHtHM=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=IDXO3pAXA2OEkKZ+B8i/r73TvnTZQ9KgwI6V6DabtsK8hslEFPRjbUclntaC0z04n I08UPCjgY+wu8DG1XFX3lLWtYmDf7WJx2Yio6c4CJdAudAOWbD1vqEMHo/OZWdkle/ GpcO6m6eElsI01ate3jx8+UTCyIv0JxgBdWKYboiMioxXaQRW6DRobnFTPjClB2lkG xIsjwOgYbRGeR5lNu1Y7wRoT98b7PeDClK9pXdZOEAIi+EU0pg6po9BG5lT7YZM6Oq Ww8hnNPC2au8t9UGPeGfhojNxDW6rkD+UnCYbETYms/Oj/u1ND7gFlNQp+O03HwZKk Fldx0oz19/a9A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/19 3:37 PM, Thomas Gleixner wrote: > On Thu, 25 Jul 2019, H. Peter Anvin wrote: >> On 7/25/19 3:03 PM, Thomas Gleixner wrote: >>> On Thu, 25 Jul 2019, hpa@zytor.com wrote: >>>> On July 25, 2019 2:48:30 PM PDT, Thomas Gleixner wrote: >>>>> >>>>> But seriously I think it's not completely insane what they are doing >>>>> and the table based approach is definitely more readable and maintainable >>>>> than the existing stuff. >>>> >>>> Doing this table based does seem like a good idea. >>> >>> The question is whether we use a 'toclear' table or a 'preserve' table. I'd >>> argue that the 'preserve' approach is saner. >>> >> I agree. > > Now we just need to volunteer someone to do that :) > Happy to jump in and do that, since I have an easy repro of the warning here. In case you missed an earlier response [1], I did have a lingering question about what you had in mind for the "to preserve" approach: [1] https://lore.kernel.org/r/ffd7a9b6-8017-2d2c-c4f7-65563094ccd0@nvidia.com thanks, -- John Hubbard NVIDIA