From: Matt Fleming <matt@console-pimps.org>
To: Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Jordan Justen <jordan.l.justen@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] x86: remove dummy long from EFI stub
Date: Sun, 04 Nov 2012 18:14:01 +0000 [thread overview]
Message-ID: <1352052841.14888.190.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1351377255-21092-2-git-send-email-cesarb@cesarb.net>
On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote:
> Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
> EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
> boot stub support), but forgot to remove the dummy long used by that
> reloc.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Matt Fleming <matt.fleming@intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
> ---
> arch/x86/boot/header.S | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 2a01744..8c132a6 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -476,6 +476,3 @@ die:
> setup_corrupt:
> .byte 7
> .string "No setup signature found...\n"
> -
> - .data
> -dummy: .long 0
This change seems fine to me. Jordan, would you mind ACKing this if
you're OK with it?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-11-04 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 22:34 Cesar Eduardo Barros
2012-11-04 18:14 ` Matt Fleming [this message]
2012-11-16 19:45 ` Justen, Jordan L
2012-11-19 8:29 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352052841.14888.190.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt@console-pimps.org \
--cc=cesarb@cesarb.net \
--cc=hpa@zytor.com \
--cc=jordan.l.justen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®