From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255Ab2KEMMt (ORCPT ); Mon, 5 Nov 2012 07:12:49 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:42232 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488Ab2KEMMq (ORCPT ); Mon, 5 Nov 2012 07:12:46 -0500 Message-ID: <1352117562.14888.277.camel@mfleming-mobl1.ger.corp.intel.com> Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y From: Matt Fleming To: Alan Cox Cc: Corentin Chary , Matthew Garrett , LKML , linux-efi@vger.kernel.org, "platform-driver-x86@vger.kernel.org" , Alessandro Crismani , Mikhail Bakhterev , Patrick H , "H. Peter Anvin" , stable@vger.kernel.org Date: Mon, 05 Nov 2012 12:12:42 +0000 In-Reply-To: <20121104193741.7b4ca37b@pyramind.ukuu.org.uk> References: <1352050506-29317-1-git-send-email-matt@console-pimps.org> <20121104193741.7b4ca37b@pyramind.ukuu.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2012-11-04 at 19:37 +0000, Alan Cox wrote: > > Acked-by: Corentin Chary > > This is totally bogus and prevents users build a kernel which can work in > either mode. As such its a regression. > > Do the detection check at runtime. If it was booted via EFI then don't > grovel in places you shouldn't. Indeed its possible EFI should reserve > those memory regions ? The kernel would have to reserve the gaps in the memory mappings since there is no mapping in the EFI memory map for 0xf0000. There is no support for that currently AFAIK. -- Matt Fleming, Intel Open Source Technology Center