mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: linux-acpi@vger.kernel.org, rjw@sisk.pl, lenb@kernel.org
Cc: linux-kernel@vger.kernel.org, joe@perches.com,
	bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com,
	vijaymohan.pandarathil@hp.com, imammedo@redhat.com,
	prarit@redhat.com, Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH v5 RESEND 4/5] ACPI: Update Container hotplug error messages
Date: Tue,  6 Nov 2012 08:02:09 -0700	[thread overview]
Message-ID: <1352214130-12055-5-git-send-email-toshi.kani@hp.com> (raw)
In-Reply-To: <1352214130-12055-1-git-send-email-toshi.kani@hp.com>

Updated Container hotplug error messages with acpi_pr_<level>()
and pr_<level>().  Removed an unnecessary check to device pointer
in acpi_container_add().

Signed-off-by: Toshi Kani <toshi.kani@hp.com>
---
 drivers/acpi/container.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
index 69e2d6b..71d77ab 100644
--- a/drivers/acpi/container.c
+++ b/drivers/acpi/container.c
@@ -110,12 +110,6 @@ static int acpi_container_add(struct acpi_device *device)
 {
 	struct acpi_container *container;
 
-
-	if (!device) {
-		printk(KERN_ERR PREFIX "device is NULL\n");
-		return -EINVAL;
-	}
-
 	container = kzalloc(sizeof(struct acpi_container), GFP_KERNEL);
 	if (!container)
 		return -ENOMEM;
@@ -177,7 +171,7 @@ static void container_notify_cb(acpi_handle handle, u32 type, void *context)
 	case ACPI_NOTIFY_BUS_CHECK:
 		/* Fall through */
 	case ACPI_NOTIFY_DEVICE_CHECK:
-		printk(KERN_WARNING "Container driver received %s event\n",
+		pr_debug("Container driver received %s event\n",
 		       (type == ACPI_NOTIFY_BUS_CHECK) ?
 		       "ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK");
 
@@ -198,7 +192,7 @@ static void container_notify_cb(acpi_handle handle, u32 type, void *context)
 
 		result = container_device_add(&device, handle);
 		if (result) {
-			printk(KERN_WARNING "Failed to add container\n");
+			acpi_pr_warn(handle, "Failed to add container\n");
 			break;
 		}
 
-- 
1.7.11.7


  parent reply	other threads:[~2012-11-06 15:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 15:02 [PATCH v5 RESEND 0/5] ACPI: hotplug messages improvement Toshi Kani
2012-11-06 15:02 ` [PATCH v5 RESEND 1/5] ACPI: Add acpi_pr_<level>() interfaces Toshi Kani
2012-11-19  8:10   ` Rafael J. Wysocki
2012-11-19 15:37     ` Toshi Kani
2012-11-20  1:17     ` Rafael J. Wysocki
2012-11-20  1:18       ` Toshi Kani
2012-11-19  8:56   ` Joe Perches
2012-11-19 15:51     ` Toshi Kani
2012-11-19 16:06       ` Joe Perches
2012-11-19 16:16         ` Toshi Kani
2012-11-19 17:35           ` Rafael J. Wysocki
2012-11-19 17:26             ` Toshi Kani
2012-11-20  1:04               ` Rafael J. Wysocki
2012-11-20  1:26                 ` Toshi Kani
2012-11-06 15:02 ` [PATCH v5 RESEND 2/5] ACPI: Update CPU hotplug error messages Toshi Kani
2012-11-06 15:02 ` [PATCH v5 RESEND 3/5] ACPI: Update Memory " Toshi Kani
2012-11-06 15:02 ` Toshi Kani [this message]
2012-11-06 15:02 ` [PATCH v5 RESEND 5/5] ACPI: Update Dock " Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352214130-12055-5-git-send-email-toshi.kani@hp.com \
    --to=toshi.kani@hp.com \
    --cc=bhelgaas@google.com \
    --cc=imammedo@redhat.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=joe@perches.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=vijaymohan.pandarathil@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®