mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuansheng Liu <chuansheng.liu@intel.com>
To: luca@coelho.fi, eliad@wizery.com
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: [PATCH 4/7] wlcore: Fix the usage of wait_for_completion_timeout
Date: Wed, 07 Nov 2012 01:28:14 +0800	[thread overview]
Message-ID: <1352222894.15558.1595.camel@cliu38-desktop-build> (raw)
In-Reply-To: <1352222555.15558.1589.camel@cliu38-desktop-build>


The return value of wait_for_completion_timeout() is always
>= 0 with unsigned int type.

So the condition "ret < 0" or "ret >= 0" is pointless.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
 drivers/net/wireless/ti/wlcore/ps.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/ps.c b/drivers/net/wireless/ti/wlcore/ps.c
index 4d1414a..ffcd843 100644
--- a/drivers/net/wireless/ti/wlcore/ps.c
+++ b/drivers/net/wireless/ti/wlcore/ps.c
@@ -151,9 +151,6 @@ int wl1271_ps_elp_wakeup(struct wl1271 *wl)
 			wl12xx_queue_recovery_work(wl);
 			ret = -ETIMEDOUT;
 			goto err;
-		} else if (ret < 0) {
-			wl1271_error("ELP wakeup completion error.");
-			goto err;
 		}
 	}
 
-- 
1.7.0.4




  parent reply	other threads:[~2012-11-06  8:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 17:18 [PATCH 1/7] I2c-nomadik: " Chuansheng Liu
2012-11-06 17:21 ` [PATCH 2/7] OMAPDSS: DISPC: " Chuansheng Liu
2012-11-06 11:30   ` Tomi Valkeinen
2012-11-06 17:22   ` [PATCH 3/7] OMAPDSS: APPLY: " Chuansheng Liu
2012-11-06 11:31     ` Tomi Valkeinen
2012-11-06 17:28     ` Chuansheng Liu [this message]
2012-11-06 17:31       ` [PATCH 5/7] can: janz-ican3: " Chuansheng Liu
2012-11-06 11:43         ` Marc Kleine-Budde
2012-11-06 17:33         ` [PATCH 6/7] mx3fb: " Chuansheng Liu
2012-11-06 17:36           ` [PATCH 7/7] IB/srpt: " Chuansheng Liu
2012-11-16 18:23       ` [PATCH 4/7] wlcore: " Luciano Coelho
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: " Wolfram Sang
2012-11-13  1:21   ` Liu, Chuansheng
2012-11-13  7:58     ` Wolfram Sang
2012-11-13  8:00       ` Liu, Chuansheng
     [not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15  8:49   ` Fwd: " Srinidhi Kasagar
2012-11-15  9:29     ` Wolfram Sang
2012-11-15  9:57       ` Srinidhi Kasagar
2012-11-15 10:18         ` Wolfram Sang
2012-11-15 11:18           ` Srinidhi Kasagar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352222894.15558.1595.camel@cliu38-desktop-build \
    --to=chuansheng.liu@intel.com \
    --cc=eliad@wizery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@coelho.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®