From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C90CB3F65EA for ; Mon, 6 Jul 2026 11:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783336188; cv=none; b=pQnuYWvfIuRi1cM96HoJlZFVq2OApRTDM1WeFH1ukLeSHptrrknZSjijOF+m81hAW1llAvFkUdS/uWimarw5YPaIjM1sMXW0rMouCEqXgQrC77zN6TRZ+uPmreQqDlFoqAxxeq1t1V3zgje3txKaQnIAOpRkOjEOocZjw1jC4Ik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783336188; c=relaxed/simple; bh=hUL4WYPSAJ761APDkAIw4UQvLSCj4JJeRyBGiBBra/U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y5nH7L3dYYMmZ1uYu9Ar8CrYaubB0tm2cjQcuu+V26HfJgHP5CRmo/SU0EaCVThu/2wnlXy5R7zIiS8SqCkQh8Gonzo76rV9d9nMT8eytN6Zt8uwVlwR4aB9m8moVobSO5lP/FeHOBAaeDkm1CH+CM3azWC+XCLRN78d1tPY8Po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pX48h7Ta; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fl7VacTT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pX48h7Ta"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fl7VacTT" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxHAf395393 for ; Mon, 6 Jul 2026 11:09:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OfCbzrTcTzIGJaYxsh7AivF35GEsErrQAAwwonLRtdM=; b=pX48h7Tawms+LHRc QZc63peXyBM/dHemiteAjFnn/Dm2atMcCHHtHjAIGSpEwCzEX76VoWqNvieJ7rMj jhuLKOBhmpaOeHAlo947z/JyekqWGxbqJGELhYB7aQA33Ur3W4V81uTtJuQt6aUe /MxPQB6y04jxto9wPJ01Rgrks3cr9GydohIvzflZsmnyRbMnQw7jtzRkiFDuO2i0 o4XEylXqicGHOBXUX7bspiKuK0uPsI9/0CDU3rDpVvoFSZJx8iBq2eX0+T5ex/dL cDQSYLJvAwrDYvPQOzv+bINABbftfw0HftfrJn7TStgNXU9IsFNkO1wHHqQxsbyO gqyJ+Q== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89qpgd1j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 11:09:45 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c21be5bb4so21574621cf.0 for ; Mon, 06 Jul 2026 04:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783336185; x=1783940985; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OfCbzrTcTzIGJaYxsh7AivF35GEsErrQAAwwonLRtdM=; b=fl7VacTTgegxSKGd+ey3esFCoakpCsR9HylmaGOJN1TTiLePhS+iATU8lL8osA2N9u 7/NfWVW812flgUn8dL0qnEksm+S92DDVkdr3KvE4A6xcEg8RPEhIJRB5Bpi3LYy9EeQ1 uQP9zuB/JK3AW4/t1ig0xgDUtC9SxgDJMpmr79sJ7zBA3vI9YtRu9tuHw4ncbK7dmOYw iZBpYWZnU7/HCenG/HMXZaVKlW+H3ObXr65PDtqKxtD3IeeVSEgSxPvrfM09AeHZEDSE 1G0DsuA+Mg/Ox/OG9Irv53kYL2Ff+M3OFjFKC+7aYUOD7G26Xi8DmdelpzpdlGK0fZ3g vNPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783336185; x=1783940985; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OfCbzrTcTzIGJaYxsh7AivF35GEsErrQAAwwonLRtdM=; b=cYfgo6AqSAuHcYPGU/AZK0DvutMnBwz1hirOMNsAbz9RzKqwKX+Tni2TdXXQPKOY7j hDp0aZMQ3cldQ3Z8ii+jINR+dynCZO+oCob+M28s/UW/CIvbd7KprWGCqhjWq46VyS22 8F6sciVR37BWziBt4bpUdigY/uedh6FdWFlc8OBqoyxLVcXdvdNBJp7V4S3AEkSfIBvS m4WSLJTwFZmdvrqH/yLXUrS525pVKI6n/+esymI5xb4SgjqJv9VUAghCqp8B0kC3qsH8 q9bAMUHt7uIAg8IN0EbH9YDiffkIX7M/LbnPNlpq+Q8McUyOVH6pwIrCwe7nGlq6bW4K 1jxw== X-Forwarded-Encrypted: i=1; AHgh+Rrb+Y9JMQcPA2RuOMuXd5zB7JUGAoUkWiF/0dkTi6KRzP6YIuVPZ32vo32nhAm3slVEqyK4rPCOtXnjP+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0rkx2zETA3P7GSMq7oV01U4Pan3LzbWwbCrIYU2wR/wrl7lcI 9bxZJ8SutM5AKgMWp19FHKQn1UGaEKjWrMo6sHdDpKzF+0Liomg9bQnvanQNOTRaV5V5WmzIC5c iStk6Cm/xl+e/cG6Uocck/Wu41YUxhjPgPT1HCq06pbgTpcpn4cPWVfHTOEswM7d0etA= X-Gm-Gg: AfdE7cmjNMVqU5I2pkzBaGNis64UnRig1KWkrdWBh5/CvCoML4+FwmGcYGKLcFL+6Nv 5BaL6etXmM2ISWkPSy9fO5FCqFZT58yAcSjmprXmll5KlTfaI09dN2y8E2IZCI7EO0PIf756qtS db/89NhbyKh6n92JyEGpU2Kz2lcCPI93dcSF9kgg8n/KrBQmrtT3pNvLdOGRMloAOedGvjYQ6lV c1SshIQyOfY10RaMCaWf6eqSYPAjM+9kQ213j8SRwECrA10zBX5s021FaJCj9u5kFTwrhgmWrBv vO3uEMOfmL14zgcBUPjnzZM73y5xBN+lbaNb0PXHz7gQXIV8a71sZGxRRy35re9ejQw/R3FGgeW kzRWZdxjfGz0J7BouLKp/cLrbCCbMLhlrOB4= X-Received: by 2002:ac8:5d0a:0:b0:517:5d21:9899 with SMTP id d75a77b69052e-51c4bdf1baamr92273081cf.5.1783336184823; Mon, 06 Jul 2026 04:09:44 -0700 (PDT) X-Received: by 2002:ac8:5d0a:0:b0:517:5d21:9899 with SMTP id d75a77b69052e-51c4bdf1baamr92272611cf.5.1783336184315; Mon, 06 Jul 2026 04:09:44 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b62c4b52sm721233166b.47.2026.07.06.04.09.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 04:09:43 -0700 (PDT) Message-ID: <13522517-8e40-436a-b6bd-5ed5f68f1da6@oss.qualcomm.com> Date: Mon, 6 Jul 2026 13:09:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/13] drm/msm: initialize LPAC ring To: Anna Maniscalco , Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20260705-descriptive-name-lpac-upstream-v1-0-01d50c3e0c99@gmail.com> <20260705-descriptive-name-lpac-upstream-v1-10-01d50c3e0c99@gmail.com> <93b78299-866f-4a3c-9423-a990d9a7d4cd@oss.qualcomm.com> <64a919ab-8b36-45fe-8da8-5eaaf4d55359@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <64a919ab-8b36-45fe-8da8-5eaaf4d55359@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=c6qbhx9l c=1 sm=1 tr=0 ts=6a4b8cf9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=mx_oZ8J27MAni7-wUjsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: hfL9CE9tE8QFipil7Jl27hlz7Xh7sUBv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDExMyBTYWx0ZWRfX8a5gFpMqX4im LicuIspDnmq1/RCpCaYc6jXaJ1+C3Hbmkp9Aji7TnHyIZqWiBg3aw/APrp+qqPmeZ5HdN/DVX/4 N+fKU5HNv1hVdoh0OuBxPNJEsBF0cu58Gby2vmDjaBjsTsB9g2an0E8lOPE/aHfKeO2JOGPN8Ei lyAC5msRMyXeNoHcyRZ+vGVBqnmzqw1B8XxEzHEpKSAibgo7+UF/E4GoDNp8Au5B9y5XWHmxQVF VGLW+twbK3h/Tv5NSpDpiOGLHVJk+3MXuQsc63lte74iF/u0OF+IXu1fUN4VS9atpBxUpaDK1/5 1/f9RJI8CBYPTjPOQptZDDCeRMAdE/Tk2E+OnbKJ3SuHNsYQRqLl/B7wGjIS0uajpHUireYe2bU 94Ea2ZL4ixYqcL9tAhOJj+ugLgkh7UaWLwmvInapGhiv0pAYN2bys4Y+YtIaoJzJijB44oinvla XmPDbLgeQhFAo7D8gmQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDExMyBTYWx0ZWRfX9iRq50cDRsWu m8Pt4CyaeU7zzieko2DOeAo/+rmP6ZMPA9FWKQ9kPfbWMXQCU+ohBG7pi49Hx53Q3dipsDzUD4a YHPTJwJriqXHdRhnT5NmvVpV26rNWd4= X-Proofpoint-GUID: hfL9CE9tE8QFipil7Jl27hlz7Xh7sUBv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060113 On 7/6/26 1:07 PM, Anna Maniscalco wrote: > On 7/6/26 10:44 AM, Konrad Dybcio wrote: >> On 7/5/26 9:13 PM, Anna Maniscalco wrote: >>> Program all the register needed to start up LPAC and send initialization >>> sequence. >>> >>> Additionally, now that the LPAC ring is live, make the code aware of it. >>> >>> Signed-off-by: Anna Maniscalco >>> --- >> I believe some/all of these writes need to be guarded by if (has_lpac), >> as many GPUs lack these registers and there may be side effects on >> others > > That's correct yeah. I'm not sure what has_lpac should be though. > > Something we add to catalog? Or checking if it is a gen that has LPAC? 'Generation' is very much an umbrella term that we can't put too much trust in in the feature department, kgsl defines it in the catalog, per-GPU. I think that's the right thing to do. > >> >> >> [...] >> >>>           a6xx_gpu->shadow = msm_gem_kernel_new(gpu->dev, >>> -                              sizeof(u32) * gpu->nr_rings, >>> +                              sizeof(u32) * (gpu->nr_rings + !!gpu->lpac_rb), >> Should we rename nr_rings to something like nr_XXX_rings >> where XXX is some uarch-generic (i.e. not SQE because we also >> support pre-a6xx) name for the main number cruncher? > Qualcom calls it GC so nr_gc_rings perhaps? I'm not in the right part of Qualcomm to know, I'll let others comment Konrad