mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] vfio: simplify kmalloc+copy_from_user to memdup_user
Date: Fri, 09 Nov 2012 14:06:29 +0100	[thread overview]
Message-ID: <1352466389.8247.79.camel@ul30vt.home> (raw)
In-Reply-To: <20121102024354.GA29600@localhost>

On Fri, 2012-11-02 at 10:43 +0800, Fengguang Wu wrote:
> Generated by: coccinelle/api/memdup_user.cocci
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  drivers/vfio/pci/vfio_pci.c |   13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> --- linux.orig/drivers/vfio/pci/vfio_pci.c	2012-10-23 18:21:57.118168335 +0800
> +++ linux/drivers/vfio/pci/vfio_pci.c	2012-11-02 10:39:36.101317628 +0800
> @@ -327,15 +327,10 @@ static long vfio_pci_ioctl(void *device_
>  			    hdr.count > vfio_pci_get_irq_count(vdev, hdr.index))
>  				return -EINVAL;
>  
> -			data = kmalloc(hdr.count * size, GFP_KERNEL);
> -			if (!data)
> -				return -ENOMEM;
> -
> -			if (copy_from_user(data, (void __user *)(arg + minsz),
> -					   hdr.count * size)) {
> -				kfree(data);
> -				return -EFAULT;
> -			}
> +			data = memdup_user((void __user *)(arg + minsz),
> +					   hdr.count * size);
> +			if (IS_ERR(data))
> +				return PTR_ERR(data);
>  		}
>  
>  		mutex_lock(&vdev->igate);


Thanks for the patch.  Looks reasonable to me.  I'll add it to my next
tree for 3.8.  Thanks,

Alex


      reply	other threads:[~2012-11-09 13:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  2:43 Fengguang Wu
2012-11-09 13:06 ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352466389.8247.79.camel@ul30vt.home \
    --to=alex.williamson@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®