From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754787Ab2KIQpU (ORCPT ); Fri, 9 Nov 2012 11:45:20 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:55288 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754729Ab2KIQpK (ORCPT ); Fri, 9 Nov 2012 11:45:10 -0500 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , Stephane Eranian , LKML , Namhyung Kim Subject: [PATCH 07/12] perf ui/browser: Add support for event group view Date: Sat, 10 Nov 2012 01:43:29 +0900 Message-Id: <1352479414-2324-8-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 1.7.9.2 In-Reply-To: <1352479414-2324-1-git-send-email-namhyung@kernel.org> References: <1352479414-2324-1-git-send-email-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Namhyung Kim Show group members' overhead also when showing the leader's if event group is enabled. At this time, only implemented overhead part in order to ease review and other parts can be added later once this patch settled down. Cc: Jiri Olsa Cc: Stephane Eranian Acked-by: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 29 ++++++++++++++++++++++++++++- tools/perf/ui/hist.c | 5 ++++- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index ccc4bd161420..ffd41cbe07df 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -567,6 +567,34 @@ static int hist_browser__show_callchain(struct hist_browser *browser, return row - first_row; } +static int hist_browser__hpp_color_overhead(struct perf_hpp *hpp, + struct hist_entry *he) +{ + int ret; + struct hists *hists = he->hists; + double percent = 100.0 * he->stat.period / hists->stats.total_period; + + /* the leader determines color */ + *(double *) hpp->ptr = percent; + + ret = scnprintf(hpp->buf, hpp->size, "%6.2f%%", percent); + + if (symbol_conf.event_group) { + int i; + struct perf_evsel *evsel = hists_2_evsel(hists); + + for (i = 0; i < evsel->nr_members; i++) { + u64 period = he->group_stats[i].period; + u64 total = hists->group_stats[i].total_period; + + percent = 100.0 * period / total; + ret += scnprintf(hpp->buf + ret, hpp->size - ret, + " %6.2f%%", percent); + } + } + return ret; +} + #define HPP__COLOR_FN(_name, _field) \ static int hist_browser__hpp_color_ ## _name(struct perf_hpp *hpp, \ struct hist_entry *he) \ @@ -577,7 +605,6 @@ static int hist_browser__hpp_color_ ## _name(struct perf_hpp *hpp, \ return scnprintf(hpp->buf, hpp->size, "%6.2f%%", percent); \ } -HPP__COLOR_FN(overhead, period) HPP__COLOR_FN(overhead_sys, period_sys) HPP__COLOR_FN(overhead_us, period_us) HPP__COLOR_FN(overhead_guest_sys, period_guest_sys) diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c index c406c94cbe53..51934a8d9e79 100644 --- a/tools/perf/ui/hist.c +++ b/tools/perf/ui/hist.c @@ -562,6 +562,9 @@ unsigned int hists__sort_list_width(struct hists *hists) { struct sort_entry *se; int i, ret = 0; + struct perf_hpp dummy_hpp = { + .ptr = hists_2_evsel(hists), + }; for (i = 0; i < PERF_HPP__MAX_INDEX; i++) { if (!perf_hpp__format[i].cond) @@ -569,7 +572,7 @@ unsigned int hists__sort_list_width(struct hists *hists) if (i) ret += 2; - ret += perf_hpp__format[i].width(NULL); + ret += perf_hpp__format[i].width(&dummy_hpp); } list_for_each_entry(se, &hist_entry__sort_list, list) -- 1.7.9.2