From: "Dmitry Kravkov" <dmitry@broadcom.com>
To: "Joseph Gasparakis" <joseph.gasparakis@intel.com>
Cc: davem@davemloft.net, shemminger@vyatta.com, chrisw@sous-sol.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH 3/3] ipgre: capture inner headers during encapsulation
Date: Sun, 11 Nov 2012 17:18:30 +0200 [thread overview]
Message-ID: <1352647110.5201.4.camel@lb-tlvb-dmitry.il.broadcom.com> (raw)
In-Reply-To: <1352427483-4380-4-git-send-email-joseph.gasparakis@intel.com>
On Thu, 2012-11-08 at 18:18 -0800, Joseph Gasparakis wrote:
>
> if (skb->ip_summed == CHECKSUM_PARTIAL &&
> skb_checksum_help(skb))
> @@ -902,6 +903,17 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
> tunnel->err_count = 0;
> }
>
> + offset = skb->data - skb->head;
> +
> + skb_reset_inner_mac_header(skb);
> +
> + if (skb->network_header)
> + skb_set_inner_network_header(skb, skb->network_header - offset);
> +
> + if (skb->transport_header)
> + skb_set_inner_transport_header(skb, skb->transport_header -
> + offset);
> +
> max_headroom = LL_RESERVED_SPACE(tdev) + gre_hlen + rt->dst.header_len;
>
> if (skb_headroom(skb) < max_headroom || skb_shared(skb)||
How it will be useful if skb_checksum_help(skb) will calculate csum? And
leaves nothing to offload
next prev parent reply other threads:[~2012-11-11 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 2:18 [PATCH net-next 0/3 ] tunneling: Add support for hardware-offloaded encapsulation Joseph Gasparakis
2012-11-09 2:18 ` [PATCH 1/3] net: " Joseph Gasparakis
2012-11-14 12:23 ` Dmitry Kravkov
2012-11-09 2:18 ` [PATCH 2/3] vxlan: capture inner headers during encapsulation Joseph Gasparakis
2012-11-09 2:18 ` [PATCH 3/3] ipgre: " Joseph Gasparakis
2012-11-11 15:18 ` Dmitry Kravkov [this message]
2012-11-12 1:47 ` Joseph Gasparakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352647110.5201.4.camel@lb-tlvb-dmitry.il.broadcom.com \
--to=dmitry@broadcom.com \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=joseph.gasparakis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®