From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163Ab2KLXTQ (ORCPT ); Mon, 12 Nov 2012 18:19:16 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:58856 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752718Ab2KLXTP (ORCPT ); Mon, 12 Nov 2012 18:19:15 -0500 Message-ID: <1352762356.18715.23.camel@joe-AO722> Subject: Re: [PATCH] checkpatch: warn about using CONFIG_EXPERIMENTAL From: Joe Perches To: Kees Cook Cc: linux-kernel@vger.kernel.org, Andy Whitcroft , Andrew Morton Date: Mon, 12 Nov 2012 15:19:16 -0800 In-Reply-To: References: <20121112225019.GA23718@www.outflux.net> <1352761583.18715.16.camel@joe-AO722> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-11-12 at 15:11 -0800, Kees Cook wrote: > On Mon, Nov 12, 2012 at 3:06 PM, Joe Perches wrote: > > On Mon, 2012-11-12 at 14:50 -0800, Kees Cook wrote: > >> + WARN("CONFIG_EXPERIMENTAL", > >> + "Use of CONFIG_EXPERIMENTAL is deprecated. " + > >> + "For alternatives, see " + > >> + "https://lkml.org/lkml/2012/10/23/580\n"); > > > > I'd much prefer this be on a single line and not using the + > > string operator as that style is not currently used in checkpatch. > > Hah. Okay. We should exclude checkpatch.pl from the 80 character check > it warns about. ;) ;) checkpatch is for .[ch] files, it isn't for anything else really.