mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alban Bedel <alban.bedel@avionic-design.de>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-kernel@vger.kernel.org, Roland Stigge <stigge@antcom.de>,
	Alexandre Pereira da Silva <aletes.xgr@gmail.com>,
	Alban Bedel <alban.bedel@avionic-design.de>
Subject: [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove
Date: Wed, 14 Nov 2012 12:58:14 +0100	[thread overview]
Message-ID: <1352894295-14339-3-git-send-email-alban.bedel@avionic-design.de> (raw)
In-Reply-To: <1352894295-14339-1-git-send-email-alban.bedel@avionic-design.de>

A single clock is used for all PWMs meaning the clock ref count might
be between 0 and N when remove() is called. Instead of a single
clk_disable() call pwm_disable() on each PWM, that ensure that
clk_disable() is called for each PWM that were still enabled.

Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
---
 drivers/pwm/pwm-lpc32xx.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/pwm/pwm-lpc32xx.c b/drivers/pwm/pwm-lpc32xx.c
index 03ec3ff..f45ce2c 100644
--- a/drivers/pwm/pwm-lpc32xx.c
+++ b/drivers/pwm/pwm-lpc32xx.c
@@ -136,8 +136,11 @@ static int lpc32xx_pwm_probe(struct platform_device *pdev)
 static int __devexit lpc32xx_pwm_remove(struct platform_device *pdev)
 {
 	struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
+	int i;
+
+	for (i = 0 ; i < lpc32xx->chip.npwm ; i += 1)
+		pwm_disable(&lpc32xx->chip.pwms[i]);
 
-	clk_disable(lpc32xx->clk);
 	return pwmchip_remove(&lpc32xx->chip);
 }
 
-- 
1.7.0.4


  parent reply	other threads:[~2012-11-14 11:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 11:58 [PATCH 0/3] pwm: lpc32xx - Various small fixes Alban Bedel
2012-11-14 11:58 ` [PATCH 1/3] pwm: lpc32xx - Fix the PWM polarity Alban Bedel
2012-11-23  9:34   ` Alexandre Pereira da Silva
2012-11-23  9:53     ` Roland Stigge
2012-11-14 11:58 ` Alban Bedel [this message]
2012-11-16 20:16   ` [PATCH 2/3] pwm: lpc32xx - Properly disable the clock on device remove Thierry Reding
     [not found]   ` <CAAAP30GTuCB6FCvM9v-ju8y5b+UhQdDnEnHALtewfOzWnD1v=A@mail.gmail.com>
2012-11-23  9:55     ` Roland Stigge
2012-11-14 11:58 ` [PATCH 3/3] pwm: lpc32xx - Set the chip base for dynamic allocation Alban Bedel
2012-11-23  9:35   ` Alexandre Pereira da Silva
2012-11-23  9:51     ` Roland Stigge
2012-11-22 21:43 ` [PATCH 0/3] pwm: lpc32xx - Various small fixes Thierry Reding
2012-12-06  7:58 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352894295-14339-3-git-send-email-alban.bedel@avionic-design.de \
    --to=alban.bedel@avionic-design.de \
    --cc=aletes.xgr@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stigge@antcom.de \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®