From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693Ab2KOJNu (ORCPT ); Thu, 15 Nov 2012 04:13:50 -0500 Received: from mga01.intel.com ([192.55.52.88]:45211 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753918Ab2KOJNs (ORCPT ); Thu, 15 Nov 2012 04:13:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.83,255,1352102400"; d="scan'208";a="247354951" Message-ID: <1352970823.2080.22.camel@rzhang1-mobl4> Subject: Re: [PATCH V5 1/2] Thermal: Add ST-Ericsson DB8500 thermal driver. From: Zhang Rui To: Hongbo Zhang Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, amit.kachhap@linaro.org, patches@linaro.org, linaro-dev@lists.linaro.org, linaro-kernel@lists.linaro.org, STEricsson_nomadik_linux@list.st.com, kernel@igloocommunity.org, "hongbo.zhang" Date: Thu, 15 Nov 2012 17:13:43 +0800 In-Reply-To: References: <1352460548-3494-1-git-send-email-hongbo.zhang@linaro.com> <1352460548-3494-2-git-send-email-hongbo.zhang@linaro.com> <1352967218.2080.15.camel@rzhang1-mobl4> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-11-15 at 16:32 +0800, Hongbo Zhang wrote: > On 15 November 2012 16:13, Zhang Rui wrote: > > On Fri, 2012-11-09 at 19:29 +0800, hongbo.zhang wrote: > >> From: "hongbo.zhang" > >> > >> This driver is based on the thermal management framework in thermal_sys.c. A > >> thermal zone device is created with the trip points to which cooling devices > >> can be bound, the current cooling device is cpufreq, e.g. CPU frequency is > >> clipped down to cool the CPU, and other cooling devices can be added and bound > >> to the trip points dynamically. The platform specific PRCMU interrupts are > >> used to active thermal update when trip points are reached. > >> > >> Signed-off-by: hongbo.zhang > >> Reviewed-by: Viresh Kumar > >> Reviewed-by: Francesco Lavra > > > >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > >> index e1cb6bd..54c8fd0 100644 > >> --- a/drivers/thermal/Kconfig > >> +++ b/drivers/thermal/Kconfig > >> @@ -31,6 +31,26 @@ config CPU_THERMAL > >> and not the ACPI interface. > >> If you want this support, you should say Y here. > >> > >> +config DB8500_THERMAL > >> + bool "DB8500 thermal management" > > > > why is this bool? > > platform specific PRCMU interfaces are used, and those interfaces are > not exported, so my driver cannot be compiled as a module. > ok. But I still alway get this error message when set DB8500_THERMAL, include/linux/mfd/dbx500-prcmu.h:459:19: error: redefinition of ‘prcmu_abb_read’ include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of ‘prcmu_abb_read’ was here include/linux/mfd/dbx500-prcmu.h:464:19: error: redefinition of ‘prcmu_abb_write’ include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of ‘prcmu_abb_write’ was here include/linux/mfd/dbx500-prcmu.h:475:19: error: redefinition of ‘prcmu_config_clkout’ include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of ‘prcmu_config_clkout’ was here include/linux/mfd/dbx500-prcmu.h:537:19: error: redefinition of ‘prcmu_ac_wake_req’ include/linux/mfd/db8500-prcmu.h:683:19: note: previous definition of ‘prcmu_ac_wake_req’ was here include/linux/mfd/dbx500-prcmu.h:542:20: error: redefinition of ‘prcmu_ac_sleep_req’ include/linux/mfd/db8500-prcmu.h:688:20: note: previous definition of ‘prcmu_ac_sleep_req’ was here $ grep prcmu_abb_read include/linux/mfd/* include/linux/mfd/db8500-prcmu.h:int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); include/linux/mfd/db8500-prcmu.h:static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size) include/linux/mfd/dbx500-prcmu.h:int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); include/linux/mfd/dbx500-prcmu.h:static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size) this functions are defined in both db8500-prmcu.h and dbx500-prcmu.h, plus linux/mfd/dbx500-prcmu.h includes linux/mfd/db8500-prcmu.h. I do not know how it works before, but this is a bug to me. thanks, rui