mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: tglx@linutronix.de, mingo@elte.hu, linuxppc-dev@ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver
Date: Thu, 17 May 2007 13:17:07 -0500	[thread overview]
Message-ID: <135307ED-7125-4859-8594-4B5B900D92D6@kernel.crashing.org> (raw)
In-Reply-To: <464C99FF.8080404@ru.mvista.com>


On May 17, 2007, at 1:07 PM, Sergei Shtylyov wrote:

> Hello.
>
> Kumar Gala wrote:
>
>>> Index: linux-2.6/arch/powerpc/kernel/time.c
>>> ===================================================================
>>> --- linux-2.6.orig/arch/powerpc/kernel/time.c
>>> +++ linux-2.6/arch/powerpc/kernel/time.c
> [...]
>>> @@ -128,6 +129,83 @@ unsigned long ppc_tb_freq;
>>>  static u64 tb_last_jiffy __cacheline_aligned_in_smp;
>>>  static DEFINE_PER_CPU(u64, last_jiffy);
>>>
>>> +#ifdef CONFIG_GENERIC_CLOCKEVENTS
>>> +
>>> +#if defined(CONFIG_40x) || defined(CONFIG_BOOKE)
>>> +#define DECREMENTER_MAX 0xffffffff
>>> +#else
>>> +#define DECREMENTER_MAX 0x7fffffff /* setting MSB triggers an   
>>> interrupt */
>>> +#endif
>>> +
>>> +static int decrementer_set_next_event(unsigned long evt,
>>> +                      struct clock_event_device *dev)
>>> +{
>>> +#if defined(CONFIG_40x)
>>> +    mtspr(SPRN_PIT, evt);    /* 40x has a hidden PIT auto- 
>>> reload  register */
>>> +#elif defined(CONFIG_BOOKE)
>>> +    mtspr(SPRN_DECAR, evt); /* Book E has  separate auto-reload   
>>> register */
>>> +    set_dec(evt);
>
>> what's the point of setting decar if you're just going to set_dec  
>> as  well?
>
>    Bothered to read the Book E specs? ;-)

I have :)

>    Loading DECAR doesn't auto-reload DEC. What I want is both set  
> the auto-reload value and start counting down from it at the same  
> time (if the decrementer is in auto-reload mode).

I see you're using DECAR to make it periodic.

> [big cut-off]
>
> WBR, Sergei

I haven't looked at all the new clock/timer code, is there any  
utility in having support for more than one clock source?

- k

  reply	other threads:[~2007-05-17 18:19 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 17:42 Sergei Shtylyov
2007-05-17 17:47 ` Kumar Gala
2007-05-17 18:07   ` Sergei Shtylyov
2007-05-17 18:17     ` Kumar Gala [this message]
2007-05-17 18:26       ` Sergei Shtylyov
2007-05-17 18:31         ` Kumar Gala
2007-05-17 18:42           ` Sergei Shtylyov
2007-05-18 12:39             ` Matt Sealey
2007-05-18 13:45               ` Sergei Shtylyov
2007-05-18 14:28                 ` Matt Sealey
2007-05-18 14:48                   ` Thomas Gleixner
2007-05-18 15:37                     ` Matt Sealey
2007-05-18 16:31                     ` Kumar Gala
2007-05-18 16:50                       ` Thomas Gleixner
2007-05-18 16:55                         ` Matt Sealey
2007-05-18 16:52                       ` Matt Sealey
2007-07-10 10:52                         ` Gabriel Paubert
2007-07-10 14:24                           ` Segher Boessenkool
2007-07-10 23:31                             ` Paul Mackerras
2007-07-11  0:10                               ` Segher Boessenkool
2007-05-18 20:27                       ` David Miller
2007-05-18 14:56       ` Daniel Walker
2007-05-18 15:06         ` Sergei Shtylyov
2007-05-18 15:39           ` Daniel Walker
2007-05-18 15:48             ` Sergei Shtylyov
2007-05-19  3:33             ` Paul Mackerras
2007-05-20  2:43               ` Daniel Walker
2007-05-20  3:03                 ` Benjamin Herrenschmidt
2007-05-20 15:03                   ` Matt Sealey
2007-05-20 21:25                     ` Benjamin Herrenschmidt
2007-05-20 16:02                   ` Segher Boessenkool
2007-05-20 21:26                     ` Benjamin Herrenschmidt
2007-05-17 19:27 ` Segher Boessenkool
2007-05-17 19:43   ` Sergei Shtylyov
2007-05-17 19:50     ` Segher Boessenkool
2007-05-17 20:00       ` Sergei Shtylyov
2007-05-17 20:53         ` Segher Boessenkool
2007-05-18  5:04           ` Benjamin Herrenschmidt
2007-05-18  5:39             ` Dave Liu
2007-05-18  7:08               ` Benjamin Herrenschmidt
2007-05-18 13:41                 ` Sergei Shtylyov
2007-05-18 13:48                   ` Sergei Shtylyov
2007-05-18 23:27                   ` Benjamin Herrenschmidt
2007-05-18 23:49                     ` Segher Boessenkool
2007-05-19  0:13                       ` Benjamin Herrenschmidt
2007-05-19  3:34                   ` Paul Mackerras
2007-05-24 18:25 ` [PATCH 2.6.21-rt7] PowerPC: fix clockevents for classic CPUs Sergei Shtylyov
2007-05-24 19:10   ` Segher Boessenkool
2007-10-18 14:45 ` [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver Sergei Shtylyov
2007-05-18  3:24 Albert Cahalan
2007-05-18 14:52 ` Sergei Shtylyov
2007-05-19  1:45   ` Albert Cahalan
2007-05-19 12:28     ` Segher Boessenkool
2007-05-19 18:22       ` Albert Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=135307ED-7125-4859-8594-4B5B900D92D6@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=sshtylyov@ru.mvista.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®