mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 7/9] irq_work: Warn if there's still work on cpu_down
Date: Sun, 18 Nov 2012 02:04:50 +0100	[thread overview]
Message-ID: <1353200692-6039-8-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1353200692-6039-1-git-send-email-fweisbec@gmail.com>

From: Steven Rostedt <rostedt@goodmis.org>

If we are in nohz and there's still irq_work to be done when the idle
task is about to go offline, give a nasty warning. Everything should
have been flushed from the CPU_DYING notifier already. Further attempts
to enqueue an irq_work are buggy because irqs are disabled by
__cpu_disable(). The best we can do is to report the issue to the user.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 kernel/irq_work.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 4ed1749..480f747 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -109,6 +109,9 @@ bool irq_work_needs_cpu(void)
 	if (llist_empty(this_list))
 		return false;
 
+	/* All work should have been flushed before going offline */
+	WARN_ON_ONCE(cpu_is_offline(smp_processor_id()));
+
 	return true;
 }
 
-- 
1.7.5.4


  parent reply	other threads:[~2012-11-18  1:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-18  1:04 [GIT PULL v2] printk: Make it usable on nohz cpus Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 1/9] irq_work: Fix racy IRQ_WORK_BUSY flag setting Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 2/9] irq_work: Fix racy check on work pending flag Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 3/9] irq_work: Remove CONFIG_HAVE_IRQ_WORK Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 4/9] nohz: Add API to check tick state Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 5/9] irq_work: Don't stop the tick with pending works Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 6/9] irq_work: Flush work on CPU_DYING Frederic Weisbecker
2012-11-18  1:04 ` Frederic Weisbecker [this message]
2012-11-18  1:04 ` [PATCH 8/9] irq_work: Make self-IPIs optable Frederic Weisbecker
2012-11-18  1:04 ` [PATCH 9/9] printk: Wake up klogd using irq_work Frederic Weisbecker
2012-12-08 15:02 ` [GIT PULL v2] printk: Make it usable on nohz cpus Ingo Molnar
2012-12-08 22:50   ` Frederic Weisbecker
  -- strict thread matches above, loose matches on Subject: below --
2012-11-16  2:21 [PATCH 0/9] printk: Make it usable on nohz cpus v6 Frederic Weisbecker
2012-11-16  2:21 ` [PATCH 7/9] irq_work: Warn if there's still work on cpu_down Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353200692-6039-8-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome