From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH v2 11/13] x86: use io_remap to access real_mode_data
Date: Sat, 17 Nov 2012 23:09:29 -0800 [thread overview]
Message-ID: <1353222571-31544-12-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1353222571-31544-1-git-send-email-yinghai@kernel.org>
When 64bit bootloader put real mode data above 4g, We can not
access real mode data directly.
because in arch/x86/kernel/head_64.S, only set ident mapping
for 0-1g, and kernel code/data/bss.
So need to move early_ioremap_init() calling from setup_arch
to x86_64_start_kernel.
Also use rsi/rdi instead of esi/edi.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/kernel/head64.c | 17 ++++++++++++++---
arch/x86/kernel/head_64.S | 4 ++--
arch/x86/kernel/setup.c | 2 ++
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index 3ac6cad..ca00d73 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -52,12 +52,21 @@ static void __init copy_bootdata(char *real_mode_data)
{
char * command_line;
unsigned long cmd_line_ptr;
+ char *p;
- memcpy(&boot_params, real_mode_data, sizeof boot_params);
+ /*
+ * for 64bit bootload path, those data could be above 4G,
+ * and we do set ident mapping for them in head_64.S.
+ * So need to ioremap to access them.
+ */
+ p = early_memremap((unsigned long)real_mode_data, sizeof boot_params);
+ memcpy(&boot_params, p, sizeof boot_params);
+ early_iounmap(p, sizeof boot_params);
cmd_line_ptr = get_cmd_line_ptr();
if (cmd_line_ptr) {
- command_line = __va(cmd_line_ptr);
+ command_line = early_memremap(cmd_line_ptr, COMMAND_LINE_SIZE);
memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
+ early_iounmap(command_line, COMMAND_LINE_SIZE);
}
}
@@ -104,7 +113,9 @@ void __init x86_64_start_kernel(char * real_mode_data)
void __init x86_64_start_reservations(char *real_mode_data)
{
- copy_bootdata(__va(real_mode_data));
+ early_ioremap_init();
+
+ copy_bootdata(real_mode_data);
memblock_reserve(__pa_symbol(&_text),
__pa_symbol(&__bss_stop) - __pa_symbol(&_text));
diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index 32fa9d0..14c5de2 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -262,9 +262,9 @@ ENTRY(secondary_startup_64)
movl initial_gs+4(%rip),%edx
wrmsr
- /* esi is pointer to real mode structure with interesting info.
+ /* rsi is pointer to real mode structure with interesting info.
pass it to C */
- movl %esi, %edi
+ movq %rsi, %rdi
/* Finally jump to run C code and to be on real kernel address
* Since we are running on identity-mapped space we have to jump
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 194e151..573fa7d7 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -718,7 +718,9 @@ void __init setup_arch(char **cmdline_p)
early_trap_init();
early_cpu_init();
+#ifdef CONFIG_X86_32
early_ioremap_init();
+#endif
setup_olpc_ofw_pgd();
--
1.7.7
next prev parent reply other threads:[~2012-11-18 7:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 7:09 [PATCH v2 00/13] x86, boot, 64bit: Add support for loading ramdisk and bzImage high Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 01/13] x86, boot: move verify_cpu.S after 0x200 Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 02/13] x86, boot: Move lldt/ltr out of 64bit code section Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 03/13] x86: Add macro for 64bit entry startup_64 Yinghai Lu
2012-11-19 22:42 ` H. Peter Anvin
2012-11-19 22:53 ` Yinghai Lu
2012-11-19 23:13 ` H. Peter Anvin
2012-11-19 23:46 ` Yinghai Lu
2012-11-19 23:55 ` H. Peter Anvin
2012-11-20 0:39 ` Yinghai Lu
2012-11-20 19:20 ` Yinghai Lu
2012-11-20 20:44 ` H. Peter Anvin
2012-11-20 20:55 ` Yinghai Lu
2012-11-20 21:12 ` H. Peter Anvin
2012-11-21 0:20 ` Yinghai Lu
2012-11-21 0:28 ` H. Peter Anvin
2012-11-21 0:32 ` Yinghai Lu
2012-11-21 0:34 ` Yinghai Lu
2012-11-21 0:45 ` H. Peter Anvin
2012-11-18 7:09 ` [PATCH v2 04/13] x86, 64bit: set extra ident page table for whole kernel range Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 05/13] x86, 64bit: add support for loading kernel above 512G Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 06/13] x86: Merge early_reserve_initrd for 32bit and 64bit Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 07/13] x86: add get_ramdisk_image/size Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 08/13] x86, boot: add get_cmd_line_ptr() Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 09/13] x86, boot: Don't check if cmd_line_ptr is accessible in misc/decompressor() Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 10/13] x86, boot: update cmd_line_ptr to unsigned long Yinghai Lu
2012-11-18 7:09 ` Yinghai Lu [this message]
2012-11-18 7:09 ` [PATCH v2 12/13] x86, boot: add fields to support load bzImage and ramdisk high Yinghai Lu
2012-11-18 7:09 ` [PATCH v2 13/13] x86: remove 1024g limitation for kexec buffer on 64bit Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353222571-31544-12-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome