From: "Eric W. Biederman" <ebiederm@xmission.com>
To: <linux-fsdevel@vger.kernel.org>
Cc: Linux Containers <containers@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>,
Zhao Hongjiang <zhaohongjiang@huawei.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH review 6/6] userns: fix return value on mntns_install() failure
Date: Mon, 19 Nov 2012 02:50:22 -0800 [thread overview]
Message-ID: <1353322222-27060-6-git-send-email-ebiederm@xmission.com> (raw)
In-Reply-To: <1353322222-27060-1-git-send-email-ebiederm@xmission.com>
From: Zhao Hongjiang <zhaohongjiang@huawei.com>
Change return value from -EINVAL to -EPERM when the permission check fails.
Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
fs/namespace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index 9ddc86f..cab78a7 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2775,7 +2775,7 @@ static int mntns_install(struct nsproxy *nsproxy, void *ns)
if (!ns_capable(mnt_ns->user_ns, CAP_SYS_ADMIN) ||
!nsown_capable(CAP_SYS_CHROOT))
- return -EINVAL;
+ return -EPERM;
if (fs->users != 1)
return -EINVAL;
--
1.7.5.4
next prev parent reply other threads:[~2012-11-19 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 10:48 [PATCH review 0/6] mount namespace container enhancements Eric W. Biederman
2012-11-19 10:50 ` [PATCH review 1/6] vfs: Allow chroot if you have CAP_SYS_CHROOT in your user namespace Eric W. Biederman
2012-11-19 10:50 ` [PATCH review 2/6] vfs: Add setns support for the mount namespace Eric W. Biederman
2012-11-19 10:50 ` [PATCH review 3/6] vfs: Add a user namespace reference from struct mnt_namespace Eric W. Biederman
2012-11-19 10:50 ` [PATCH review 4/6] vfs: Only support slave subtrees across different user namespaces Eric W. Biederman
2012-11-19 10:50 ` [PATCH review 5/6] vfs: Allow unprivileged manipulation of the mount namespace Eric W. Biederman
2012-11-19 10:50 ` Eric W. Biederman [this message]
2012-11-20 3:19 ` [PATCH review 0/6] mount namespace container enhancements Gao feng
2012-11-20 4:29 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353322222-27060-6-git-send-email-ebiederm@xmission.com \
--to=ebiederm@xmission.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®