From: YAMANE Toshiaki <yamanetoshi@gmail.com>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, YAMANE Toshiaki <yamanetoshi@gmail.com>
Subject: [PATCH 03/16] staging/rtl8187se: Use pr_ printks in ieee80211/ieee80211_crypt.c
Date: Tue, 20 Nov 2012 21:10:57 +0900 [thread overview]
Message-ID: <1353413457-24512-1-git-send-email-yamanetoshi@gmail.com> (raw)
In-Reply-To: <1353413395-24444-1-git-send-email-yamanetoshi@gmail.com>
The following warnings fixed.
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
and add pr_fmt.
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
---
.../staging/rtl8187se/ieee80211/ieee80211_crypt.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
index 934b915..623245c 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
@@ -11,6 +11,8 @@
*
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
//#include <linux/config.h>
#include <linux/module.h>
#include <linux/init.h>
@@ -66,8 +68,7 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
spin_lock_irqsave(&ieee->lock, flags);
ieee80211_crypt_deinit_entries(ieee, 0);
if (!list_empty(&ieee->crypt_deinit_list)) {
- printk(KERN_DEBUG "%s: entries remaining in delayed crypt "
- "deletion list\n", ieee->dev->name);
+ pr_debug("entries remaining in delayed crypt deletion list\n");
ieee->crypt_deinit_timer.expires = jiffies + HZ;
add_timer(&ieee->crypt_deinit_timer);
}
@@ -118,8 +119,7 @@ int ieee80211_register_crypto_ops(struct ieee80211_crypto_ops *ops)
list_add(&alg->list, &hcrypt->algs);
spin_unlock_irqrestore(&hcrypt->lock, flags);
- printk(KERN_DEBUG "ieee80211_crypt: registered algorithm '%s'\n",
- ops->name);
+ pr_debug("registered algorithm '%s'\n", ops->name);
return 0;
}
@@ -146,8 +146,7 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
spin_unlock_irqrestore(&hcrypt->lock, flags);
if (del_alg) {
- printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm "
- "'%s'\n", ops->name);
+ pr_debug("unregistered algorithm '%s'\n", ops->name);
kfree(del_alg);
}
@@ -234,9 +233,8 @@ void ieee80211_crypto_deinit(void)
alg = list_entry(ptr, struct ieee80211_crypto_alg, list);
if (alg) {
list_del(ptr);
- printk(KERN_DEBUG
- "ieee80211_crypt: unregistered algorithm '%s' (deinit)\n",
- alg->ops->name);
+ pr_debug("unregistered algorithm '%s' (deinit)\n",
+ alg->ops->name);
kfree(alg);
}
}
--
1.7.9.5
next prev parent reply other threads:[~2012-11-20 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 12:09 [PATCH 01/16] staging/rtl8187se: Fix spacing coding style in r8180_dm.h YAMANE Toshiaki
2012-11-20 12:10 ` [PATCH 02/16] staging/rtl8187se: Fix include file issue in ieee80211/ieee80211_crypt.c YAMANE Toshiaki
2012-11-20 12:10 ` YAMANE Toshiaki [this message]
2012-11-20 12:11 ` [PATCH 04/16] staging/rtl8187se: Fix spacing coding style " YAMANE Toshiaki
2012-11-20 12:11 ` [PATCH 05/16] staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_crypt.h YAMANE Toshiaki
2012-11-20 12:11 ` [PATCH 06/16] staging/rtl8187se: Fix include file issue in ieee80211/ieee80211_module.c YAMANE Toshiaki
2012-11-20 12:11 ` [PATCH 07/16] staging/rtl8187se: Use netdev_ printks " YAMANE Toshiaki
2012-11-20 12:12 ` [PATCH 08/16] staging/rtl8187se: Fix spacing coding style " YAMANE Toshiaki
2012-11-20 12:12 ` [PATCH 09/16] staging/rtl8187se: Fix include file issue in ieee80211/ieee80211_crypt_ccmp.c YAMANE Toshiaki
2012-11-20 12:12 ` [PATCH 10/16] staging/rtl8187se: Fix spacing coding style " YAMANE Toshiaki
2012-11-20 12:12 ` [PATCH 11/16] staging/rtl8187se: Use pr_ printks " YAMANE Toshiaki
2012-11-20 12:13 ` [PATCH 12/16] staging/rtl8187se: Fix spacing coding style " YAMANE Toshiaki
2012-11-20 12:13 ` [PATCH 13/16] staging/rtl8187se: Fix include file issue in ieee80211/ieee80211_crypt_wep.c YAMANE Toshiaki
2012-11-20 12:13 ` [PATCH 14/16] staging/rtl8187se: Fix spacing coding style " YAMANE Toshiaki
2012-11-20 12:13 ` [PATCH 15/16] staging/rtl8187se: Use pr_ printks " YAMANE Toshiaki
2012-11-20 12:13 ` [PATCH 16/16] staging/rtl8187se: Fix spacing coding style " YAMANE Toshiaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353413457-24512-1-git-send-email-yamanetoshi@gmail.com \
--to=yamanetoshi@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®