mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Andy Whitcroft" <apw@canonical.com>
Cc: "Joe Perches" <joe@perches.com>,
	"David Rientjes" <rientjes@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] checkpatch: add double empty line check
Date: Tue, 20 Nov 2012 22:26:23 +0200	[thread overview]
Message-ID: <1353443183.10779.12.camel@lb-tlvb-eilong.il.broadcom.com> (raw)
In-Reply-To: <20121120201142.GI17797@dm>

On Tue, 2012-11-20 at 20:11 +0000, Andy Whitcroft wrote:
> > 
> > Actually the version I sent should indeed cope with the deleted lines
> > regardless of order.  It was cirtainly intended to.
> 
> ... and I think I thought of a couple more corner cases neither solution
> will find.  So I am going to go away and make up a proper set of tests
> for this apparently simple change.  As it is really annoying when it
> false positives.  I will post against when I have something which works.
> 

Thanks Andy!

I will assist in testing it on all the scenarios I have created once you
post it.

I appreciate you taking the time to look into adding a test for this
issue.

Thanks,
Eilon



  reply	other threads:[~2012-11-20 20:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17 11:17 Eilon Greenstein
2012-11-20 11:52 ` Andy Whitcroft
2012-11-20 14:27   ` Eilon Greenstein
2012-11-20 14:43     ` Andy Whitcroft
2012-11-20 15:07       ` Eilon Greenstein
2012-11-20 15:44         ` Andy Whitcroft
2012-11-20 16:06           ` Eilon Greenstein
2012-11-20 16:14             ` Andy Whitcroft
2012-11-20 16:22               ` Eilon Greenstein
2012-11-20 16:36                 ` Andy Whitcroft
2012-11-20 16:36               ` Andy Whitcroft
2012-11-20 19:10                 ` Eilon Greenstein
2012-11-20 19:32                   ` Andy Whitcroft
2012-11-20 20:11                     ` Andy Whitcroft
2012-11-20 20:26                       ` Eilon Greenstein [this message]
2012-11-20 21:58   ` Joe Perches
2012-11-20 23:19     ` Andy Whitcroft
2012-11-20 23:41       ` Joe Perches
2012-11-21  9:42         ` Eilon Greenstein
2012-11-21 15:01           ` Joe Perches
2012-11-21 15:45             ` Eilon Greenstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353443183.10779.12.camel@lb-tlvb-eilong.il.broadcom.com \
    --to=eilong@broadcom.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®