mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: linux-acpi@vger.kernel.org, rjw@sisk.pl, lenb@kernel.org
Cc: linux-kernel@vger.kernel.org, joe@perches.com,
	bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com,
	vijaymohan.pandarathil@hp.com, Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH v6 0/5] ACPI: hotplug messages improvement
Date: Tue, 20 Nov 2012 13:44:49 -0700	[thread overview]
Message-ID: <1353444294-25575-1-git-send-email-toshi.kani@hp.com> (raw)

This patchset improves logging messages for ACPI CPU, Memory, 
Container and Dock hotplug notify handlers.  The patchset 
introduces a set of new macro interfaces, acpi_handle_<level>(),
and uses them to update the notify handlers.

acpi_handle_<level>() appends "ACPI" prefix and ACPI object path
to the messages, which has similar usage model as dev_<level>().
This improves diagnosis of hotplug operations since an error
message in a log file identifies an object that caused an issue.

The patchset is based on the linux-next branch of linux-pm.git
tree.

v6:
 - Changed the interface name to acpi_handle_<level>(), and
   declared them in include/linux/acpi.h.
 - Added __printf(3,4) to acpi_handle_printk() prototype.
 - Documented the interfaces acquire the global namespace mutex
   and may not be called from interrupt context.

v5:
 - Added update for ACPI Dock hotplug error messages.
 - Added error status / ID info to the messages where needed.

v4:
 - Changed to use dev_<level>() where it is appropriate.

v3:
 - Changed acpi_pr_debug() to NOP when !DEBUG and !DYNAMIC_DEBUG.
   DYNAMIC_DEBUG will be supported later when necessary.
 - Added const to a path variable in acpi_printk().
 - Added more descriptions to the change log of patch 1/4.

v2:
 - Set buffer.pointer to NULL in acpi_printk().
 - Added acpi_pr_debug().

---
Toshi Kani (5):
 ACPI: Add acpi_handle_<level>() interfaces
 ACPI: Update CPU hotplug error messages
 ACPI: Update Memory hotplug error messages
 ACPI: Update Container hotplug error messages
 ACPI: Update Dock hotplug error messages

---
 drivers/acpi/acpi_memhotplug.c  | 24 ++++++++++++-----------
 drivers/acpi/container.c        | 10 ++--------
 drivers/acpi/dock.c             | 30 ++++++++++++++--------------
 drivers/acpi/processor_driver.c | 39 +++++++++++++++++++++++--------------
 drivers/acpi/utils.c            | 37 +++++++++++++++++++++++++++++++++++
 include/linux/acpi.h            | 43 +++++++++++++++++++++++++++++++++++++++++
 6 files changed, 133 insertions(+), 50 deletions(-)

             reply	other threads:[~2012-11-20 20:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 20:44 Toshi Kani [this message]
2012-11-20 20:44 ` [PATCH v6 1/5] ACPI: Add acpi_handle_<level>() interfaces Toshi Kani
2012-11-20 21:10   ` Joe Perches
2012-11-20 21:12     ` Toshi Kani
2012-11-20 20:44 ` [PATCH v6 2/5] ACPI: Update CPU hotplug error messages Toshi Kani
2012-11-20 20:44 ` [PATCH v6 3/5] ACPI: Update Memory " Toshi Kani
2012-11-20 20:44 ` [PATCH v6 4/5] ACPI: Update Container " Toshi Kani
2012-11-20 20:44 ` [PATCH v6 5/5] ACPI: Update Dock " Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353444294-25575-1-git-send-email-toshi.kani@hp.com \
    --to=toshi.kani@hp.com \
    --cc=bhelgaas@google.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=joe@perches.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=vijaymohan.pandarathil@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®