From: Chuansheng Liu <chuansheng.liu@intel.com>
To: akpm@linux-foundation.org, dzickus@redhat.com, mingo@kernel.org,
rjw@sisk.pl
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: [PATCH] watchdog: optimizing the hrtimer interval for power saving
Date: Fri, 23 Nov 2012 00:48:26 +0800 [thread overview]
Message-ID: <1353602906.15558.1695.camel@cliu38-desktop-build> (raw)
By default, the watchdog threshold is 10, it means every 4s
every CPU will receive one hrtimer interrupt, for low power
device, it will cause 4-5mV power impact when device is deep
sleep.
So here want to optimize it as below:
4s + 4s + 4s + 4s + 4s
== >
12s + 2s + 2s + 2s + 2s
3/5 1/10 1/10 1/10 1/10
In 5 chances, once one chance is hit, then we can start the
hrtimer with a longer period sample(12s). Until the current
chance is not hit, will start the hrtimer with a shorted
period sample(2s).
With this patch, in most case the hrtimer will be 12s instead
of 4s averagely. It can save the device power indeed.
Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
kernel/watchdog.c | 30 ++++++++++++++++++++++++++++--
1 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index dd4b80a..6457e62 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -125,7 +125,24 @@ static u64 get_sample_period(void)
* and hard thresholds) to increment before the
* hardlockup detector generates a warning
*/
- return get_softlockup_thresh() * ((u64)NSEC_PER_SEC / 5);
+ return get_softlockup_thresh() * ((u64)NSEC_PER_SEC / 10);
+}
+
+static u64 get_long_sample_period(void)
+{
+ /*
+ * convert watchdog_thresh from seconds to ns
+ * We want to give 5 chances to detect softlockup,
+ * for power saving, once one chance is succeeding,
+ * we can set long period to avoid power consumption.
+ * Currently, set the long sample period is:
+ * 20s * 3/5 = 12s, once this 12s chance is not hit,
+ * we will divide the left 8s into 4 pieces, give every
+ * chance every 2s, so it will be likely:
+ * 12s + 2s + 2s + 2s + 2s,
+ * Anyway, we just use 12s is enough in normal case.
+ */
+ return get_softlockup_thresh() * ((u64)NSEC_PER_SEC * 3 / 5);
}
/* Commands for resetting the watchdog */
@@ -267,6 +284,10 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
unsigned long touch_ts = __this_cpu_read(watchdog_touch_ts);
struct pt_regs *regs = get_irq_regs();
int duration;
+ bool is_touched;
+
+ is_touched = (__this_cpu_read(hrtimer_interrupts) ==
+ __this_cpu_read(soft_lockup_hrtimer_cnt));
/* kick the hardlockup detector */
watchdog_interrupt_count();
@@ -275,7 +296,12 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
wake_up_process(__this_cpu_read(softlockup_watchdog));
/* .. and repeat */
- hrtimer_forward_now(hrtimer, ns_to_ktime(get_sample_period()));
+ if (is_touched) {
+ hrtimer_forward_now(hrtimer,
+ ns_to_ktime(get_long_sample_period()));
+ } else {
+ hrtimer_forward_now(hrtimer, ns_to_ktime(get_sample_period()));
+ }
if (touch_ts == 0) {
if (unlikely(__this_cpu_read(softlockup_touch_sync))) {
--
1.7.0.4
next reply other threads:[~2012-11-22 19:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 16:48 Chuansheng Liu [this message]
2012-11-26 20:09 ` Don Zickus
2012-11-28 0:51 ` Liu, Chuansheng
2012-11-28 11:24 ` [PATCH V2] " Chuansheng Liu
2012-11-28 15:42 ` Don Zickus
2012-11-29 0:30 ` Liu, Chuansheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353602906.15558.1695.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®