mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Tero Kristo <t-kristo@ti.com>,
	Grazvydas Ignotas <notasas@gmail.com>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	<devicetree-discuss@lists.ozlabs.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>, <linux-doc@vger.kernel.org>
Subject: [PATCH v4 0/3] pwm: Drivers for twl4030/6030 PWMs and LEDs
Date: Tue, 27 Nov 2012 11:09:56 +0100	[thread overview]
Message-ID: <1354010999-31371-1-git-send-email-peter.ujfalusi@ti.com> (raw)

Hello,

Changes since v3:
- pwm-twl-led driver's comment fix patch squashed to the original patch
- Documentation for the DT bindings of the PWM drivers
Comments from Thierry Reding addressed:
- pwm-twl6030 has been removed in the last patch
- macro for twl_pwm_chip/twl_pwmled_chip lookup
- locking for read-modify-write sequences
- separate pwm_ops strictures for twl4030 and twl6030 class
- _devexit_P() removed
- Do not select HAVE_PWM in Kconfig file since it is going away AFAIK:
  https://patchwork.kernel.org/patch/1544851/
- Remaining (smaller) comments from Thierry also has been addressed.

Changes since v2:
- New PWM cycle calculation for twl-pwm driver and twl4030's pwm-twl-led with
  comment to document the expected behaviour.

Changes cince v1:
- The turn on/off sequence has been corrected for twl4030 PWMs as suggested by
  Grazvydas Ignotas
- Comment section added to the new drivers to describe what they are controlling

The series has been tested (with additional, pending patches):
Zoom2 for twl4030 PWM0 (keypad light), PWM1 (LCD backlight)
BeagleBoard for twl4030 LEDB (PWMB - pmu_stat led)
OMAP4 Blaze (SDP4430) for twl6030 PWM1 (keypad light), PWM2 (LCD backlight) and
LED (charging indication led).

Intro mail from v1:

The currently available pwm-twl6030.c driver only supports TWL6030's Charging
indication LED.
Remove this driver and add two new ones which implements support for all PWM
driven outputs:
pwm-twl driver supports twl4030 (PWM 0/1) and twl6030 (PWM 1/2) instances
pwm-twl-led driver supports twl4030 (PWM driven LED A/B ports) and twl6030's
Charging indication LED (PWM driven).

Regards,
Peter
---
Peter Ujfalusi (3):
  pwm: New driver to support PWMs on TWL4030/6030 series of PMICs
  pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of
    PMICs
  pwm: Remove pwm-twl6030 driver

 .../devicetree/bindings/pwm/ti,twl-pwm.txt         |  17 +
 .../devicetree/bindings/pwm/ti,twl-pwmled.txt      |  17 +
 drivers/pwm/Kconfig                                |  17 +-
 drivers/pwm/Makefile                               |   3 +-
 drivers/pwm/pwm-twl-led.c                          | 342 ++++++++++++++++++++
 drivers/pwm/pwm-twl.c                              | 357 +++++++++++++++++++++
 drivers/pwm/pwm-twl6030.c                          | 184 -----------
 7 files changed, 748 insertions(+), 189 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt
 create mode 100644 drivers/pwm/pwm-twl-led.c
 create mode 100644 drivers/pwm/pwm-twl.c
 delete mode 100644 drivers/pwm/pwm-twl6030.c

-- 
1.8.0


             reply	other threads:[~2012-11-27 10:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 10:09 Peter Ujfalusi [this message]
2012-11-27 10:09 ` [PATCH v4 1/3] pwm: New driver to support PWMs on TWL4030/6030 series of PMICs Peter Ujfalusi
2012-11-27 10:09 ` [PATCH v4 2/3] pwm: New driver to support PWM driven LEDs " Peter Ujfalusi
2012-11-27 10:09 ` [PATCH v4 3/3] pwm: Remove pwm-twl6030 driver Peter Ujfalusi
2012-11-28 14:20 ` [PATCH v4 0/3] pwm: Drivers for twl4030/6030 PWMs and LEDs Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354010999-31371-1-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=notasas@gmail.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=t-kristo@ti.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®