From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932243Ab2K3JS1 (ORCPT ); Fri, 30 Nov 2012 04:18:27 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:41256 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206Ab2K3JSZ (ORCPT ); Fri, 30 Nov 2012 04:18:25 -0500 Message-ID: <1354267101.2259.11.camel@dabdike.int.hansenpartnership.com> Subject: Re: [PATCH 5/5] arcmsr: Modify ARC-1214 IO Behavior From: James Bottomley To: NickCheng Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jejb@kernel.org Date: Fri, 30 Nov 2012 09:18:21 +0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-11-16 at 19:56 +0800, NickCheng wrote: > From: Nick Cheng > > Modify ARC-1214 IO behavior to make up for HW seldom malfunction. > Signed-off-by: Nick Cheng This still isn't right. I said you could ignore most of the warnings (like lines over 80 characters), but you have a lot of this: > - printk(KERN_NOTICE "arcmsr%d: memory mapping region fail \n", = > acb->host->host_no); > + pr_notice("arcmsr%d: memory mapping" > + "region fail\n", acb->host->host_no); I'm agnostic on whether you split a print, in spite of the warning but I do tend to prefer longer lines, since they avoid the mistake you made quite a few times, which is not leaving a space between the separate words in the split string. This will produce a message like arcmsr1: memory mappingregion fail Plus this indentation > - if (readl(&acb->pmuC->outbound_doorbell) & ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE) { > - writel(ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE_DOORBELL_CLEAR, &acb->pmuC->outbound_doorbell_clear);/*clear interrupt*/=0A= > + if (readl(&acb->pmuC->outbound_doorbell) & > + ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE) { > + writel(ARCMSR_HBCMU_IOP2DRV_MESSAGE_CMD_DONE_DOORBELL_CLEAR, > + &acb->pmuC->outbound_doorbell_clear); Is being changed from correctly indented to incorrectly indented (writel needs another tab). James