From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758515Ab2K3O5n (ORCPT ); Fri, 30 Nov 2012 09:57:43 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:56761 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758499Ab2K3O5l (ORCPT ); Fri, 30 Nov 2012 09:57:41 -0500 Message-ID: <1354287460.11903.8.camel@joe-AO722> Subject: Re: [PATCH 3/3] cifs: Enable Kconfig control of CIFS_DEBUG From: Joe Perches To: Jeff Layton Cc: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Date: Fri, 30 Nov 2012 06:57:40 -0800 In-Reply-To: <20121130065629.52c489dc@tlielax.poochiereds.net> References: <5f5c9196b44908026a27333ef31dd4ebf4314de2.1354217746.git.joe@perches.com> <20121130065629.52c489dc@tlielax.poochiereds.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-11-30 at 06:56 -0500, Jeff Layton wrote: > On Thu, 29 Nov 2012 11:37:20 -0800 > Joe Perches wrote: > > > Rather than havign a permanently enabled #define, allow > > control over it. > > > > This can reduce the size of the module by ~100KB which > > could be useful for embedded systems. [] > > diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h > > index 4d12fe4..6867a7f 100644 > > --- a/fs/cifs/cifs_debug.h > > +++ b/fs/cifs/cifs_debug.h > > @@ -18,7 +18,10 @@ > > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > > * > > */ > > -#define CIFS_DEBUG /* BB temporary */ > > + > > +#ifdef CONFIG_CIFS_DEBUG > > +#define CIFS_DEBUG > > +#endif > > > > #ifndef _H_CIFS_DEBUG > > #define _H_CIFS_DEBUG > > Looks fine, but I'd probably prefer to just get rid of CIFS_DEBUG > altogether here and replace it with CONFIG_CIFS_DEBUG. I wasn't sure if there was other code anywhere else that depends on CIFS_DEBUG. There isn't any in the kernel source tree. If not, then you are right, it should be just CONFIG_CIFS_DEBUG. > While you're at it, /proc/fs/cifs/cifsFYI should probably not be > present when CONFIG_CIFS_DEBUG isn't set. Perhaps we should also > disable traceSMB and its related functions too in that case? That could be considered a kernel api change. If people agree to delete it, I'd be OK with it.