From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754070Ab2LBXMy (ORCPT ); Sun, 2 Dec 2012 18:12:54 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:14644 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017Ab2LBXMx (ORCPT ); Sun, 2 Dec 2012 18:12:53 -0500 X-AuditID: cbfee61b-b7f616d00000319b-f5-50bbe0724eb0 Message-id: <1354489942.18849.10.camel@kjgkr> Subject: Re: [PATCH -next] f2fs: remove unused variable From: Jaegeuk Kim Reply-to: jaegeuk.kim@samsung.com To: Wei Yongjun Cc: yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Mon, 03 Dec 2012 08:12:22 +0900 In-reply-to: References: Organization: samsung Content-type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-cREHpINfEJPAQ9qCcdLN" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-version: 1.0 DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42I5/e+ZkW7Rg90BBu+65Cwu75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAldG893Mgh6Jii3bv7I1MF4T6WLk5JAQMJE4dK2PEcIWk7hwbz1b FyMXh5DAMkaJpXeOsMMUvWq+ywyRmM4o8WbafCYIp4dJ4uqpq0wgVbwCuhKXrm0Gs4UFzCX+ nd4JNJaDg01AW2LzfgOQsJCAosTb/XdZQcIiAioS767Xg4SZBTIl5t84ywpiswioSryfN50F xOYUCJY41nqZHaI1QOLF5DnMIDa/gKjEydZPjBC9VRJ7V/UwQdypJLG7vZMd4hpBiR+T77FA zBSQ+Db5EAvIWgkBWYlNB8BekRC4xi5xbOkpqF5JiYMrbrBMYBSfhWTsLCSjIOKaEq3bf7ND 2NoSyxa+ZoawbSXWrXsPVWMjsenqAkYIW15i+9s5zAsY2VcxiqYWJBcUJ6XnGukVJ+YWl+al 6yXn525ihMSh9A7GVQ0WhxgFOBiVeHgTFu8KEGJNLCuuzD3EqAI059GG1RcYpVjy8vNSlUR4 F1fsDhDiTUmsrEotyo8vKs1JLT7EmAz06URmKdHkfGDqyCuJNzQ2NjEzMTUxtzQ1NyVNWEmc t9kjJUBIID2xJDU7NbUgtQhmCxMHp1QDo7nW+kfdFw92FIRvXMDYfk+71qXxROMJv+TaPQ0d JZoCFjbZV/0X1ylH9Yuz8TSntJ87Z/nPaae/xZcVjcv3fj6/k6Vk73XnEy3vny45ZbkxLdNA ysais2jZAb67Lfa9Vnl758XrvX/B+d9Xp/5w6gXLNYfe6b1dqiFXGapiMEFulcfbz8talViK MxINtZiLihMBci5eHhMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsVy+t9jQd2iB7sDDA7dlLS4vGsOmwOjx+dN cgGMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlA U5UUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGc13Mwt6JCq2bP/K1sB4 TaSLkZNDQsBE4lXzXWYIW0ziwr31bF2MXBxCAtMZJd5Mm88E4fQwSVw9dZUJpIpXQFfi0rXN YLawgLnEv9M7GbsYOTjYBLQlNu83AAkLCShKvN1/lxUkLCKgIvHuej1ImFkgU2L+jbOsIDaL gKrE+3nTWUBsToFgiWOtl9khWgMkXkyeA3YPv4CoxMnWT4wQvVUSe1f1MEHcqSSxu72THeIa QYkfk++xTGAUnIWkbBaSFERcU6J1+292CFtbYtnC18wQtq3EunXvoWpsJDZdXcAIYctLbH87 h3kBI/sqRtHUguSC4qT0XCO94sTc4tK8dL3k/NxNjOAofya9g3FVg8UhRgEORiUe3oTFuwKE WBPLiitzDzGqAM15tGH1BUYplrz8vFQlEd7FFbsDhHhTEiurUovy44tKc1KLDzEmA0NjIrOU aHI+MDHllcQbGpuYGVkamVkYmZibkyasJM7b7JESICSQnliSmp2aWpBaBLOFiYNTqoGR4ceX 7R8Fr+1avvW774tbDM1vjq37I53jcX1p2PaqTmldXynzojO7/b9fPfnp6dxiq5iC3aXtb+XU 3a6y3TLZqzvRuvBadfaijnkXlf7YytjfEz1aVzvr+8Ggo4s3OJzNDhIMCX98zCF7qx9XYrD6 N7/wpVu3OTsZ+lf8FpkZ4shpqbXU70miEktxRqKhFnNRcSIA5Yz4VkIDAAA= X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-cREHpINfEJPAQ9qCcdLN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Merged. Thanks, Add CC: linux-f2fs-devel@lists.sourceforge.net 2012-12-02 (=EC=9D=BC), 08:11 -0500, Wei Yongjun: > From: Wei Yongjun >=20 > The variables node_page and page_offset are initialized but never used > otherwise, so remove those unused variables. >=20 > Signed-off-by: Wei Yongjun > --- > fs/f2fs/file.c | 2 -- > fs/f2fs/dir.c | 2 -- > 2 files changed, 4 deletions(-) >=20 > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index f5ae36d..69e05c6 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -30,7 +30,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *= vma, > struct page *page =3D vmf->page; > struct inode *inode =3D vma->vm_file->f_path.dentry->d_inode; > struct f2fs_sb_info *sbi =3D F2FS_SB(inode->i_sb); > - struct page *node_page; > block_t old_blk_addr; > struct dnode_of_data dn; > int err; > @@ -50,7 +49,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *= vma, > } > =20 > old_blk_addr =3D dn.data_blkaddr; > - node_page =3D dn.node_page; > =20 > if (old_blk_addr =3D=3D NULL_ADDR) { > err =3D reserve_new_block(&dn); >=20 > diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > index 5975568..6891e45 100644 > --- a/fs/f2fs/dir.c > +++ b/fs/f2fs/dir.c > @@ -509,13 +509,11 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentr= y, struct page *page, > } > =20 > if (bit_pos =3D=3D NR_DENTRY_IN_BLOCK) { > - loff_t page_offset; > truncate_hole(dir, page->index, page->index + 1); > clear_page_dirty_for_io(page); > ClearPageUptodate(page); > dec_page_count(sbi, F2FS_DIRTY_DENTS); > inode_dec_dirty_dents(dir); > - page_offset =3D page->index << PAGE_CACHE_SHIFT; > f2fs_put_page(page, 1); > } else { > f2fs_put_page(page, 1); >=20 >=20 --=20 Jaegeuk Kim Samsung --=-cREHpINfEJPAQ9qCcdLN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJQu+BWAAoJEEAUqH6CSFDSTv4P/3z2tOP6oTgXG6gKfM6T9DOR iVVupm4BS2U4et2TBa9Wl8fCYurezdL2t5qDJyXGR4XnqYrLuX7fbCbWMBOzqhf6 sA+Ifhqm5eEZSn9T5cmOyERdpQ0Ogq8Ufo4thoiP9Ii/NL1dwW98bEduCFH5nOIf N069suMXAy3fp5XP1GoQCbvC/b2/ofqgTFPGv+bV2bXD73tQ7O4LJSSYTnMC/eRi eO1nk1/S+RAk/Ua3ksZAMZJYCLas7cKhuXBApn5vrgAGHUE6JJ4T4yCoRXKU9/H1 3OUuxY+Mx0FgSJSWg3+GO/I++3EtdbKyTuxw/FVqq4poHj2t23Xztb12b6Ce9be5 Ed6r0kAkD66sfZoCcxcsuK6Q5HGSL3uKes7BGI4Op5IsNsCYVbiZZZ32gpGfxxDy 6UlSjpDBqcnYHcZf+UBGqnB0qWEgzBk4PL6Z4lPCrOmDzGNvbMvLu895QE+GV3HR wxKcqwhA4MTi5H0nSGh/vV5lh9qEfAW7t4uRSSWM/U9RPxn8KCH3l2ZElTu3GPWi wFb7ZkU47LijHnmYjXFWcLHkCGDwj562vGa3yD6GabcBHSGjNTWqWQMhVpvpC7en uGHKiVwej8sh6Ky6+64KeqMyqmcWa7wzQSo8h3R9C+kWxfIdysqZqkCBl8zRZWhb 1UXniWUfZiiGKwDpuyO9 =+kAQ -----END PGP SIGNATURE----- --=-cREHpINfEJPAQ9qCcdLN--