mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qing Xu <qingx@marvell.com>
To: qingx@marvell.com, zhouqiao@marvell.com, sameo@linux.intel.com,
	tianxf@marvell.com, cxie4@marvell.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH] mfd: 88pm80x: fix no interrupt mask reg
Date: Mon,  3 Dec 2012 16:11:25 +0800	[thread overview]
Message-ID: <1354522285-7563-1-git-send-email-qingx@marvell.com> (raw)

From: Qing Xu <qingx@marvell.com>

1.88pm80x do not have interrupt mask registers and we use
interrupt enable register. So we need to set mask_invert flag.
2.add support for D0 version

Signed-off-by: Xiaofan Tian <tianxf@marvell.com>
Signed-off-by: Qing Xu <qingx@marvell.com>
---
 drivers/mfd/88pm800.c |    4 +++-
 drivers/mfd/88pm805.c |    1 +
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index e1525ab..3fcc8dd 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -119,7 +119,8 @@ enum {
 	PM800_CHIP_A1  = 0x61,
 	PM800_CHIP_B0  = 0x62,
 	PM800_CHIP_C0  = 0x63,
-	PM800_CHIP_END = PM800_CHIP_C0,
+	PM800_CHIP_D0  = 0x64,
+	PM800_CHIP_END = PM800_CHIP_D0,
 
 	/* Make sure to update this to the last stepping */
 	PM8XXX_CHIP_END = PM800_CHIP_END
@@ -362,6 +363,7 @@ static struct regmap_irq_chip pm800_irq_chip = {
 	.status_base = PM800_INT_STATUS1,
 	.mask_base = PM800_INT_ENA_1,
 	.ack_base = PM800_INT_STATUS1,
+	.mask_invert = 1,
 };
 
 static int pm800_pages_init(struct pm80x_chip *chip)
diff --git a/drivers/mfd/88pm805.c b/drivers/mfd/88pm805.c
index 8c9e25a..39a91bd 100644
--- a/drivers/mfd/88pm805.c
+++ b/drivers/mfd/88pm805.c
@@ -187,6 +187,7 @@ static struct regmap_irq_chip pm805_irq_chip = {
 	.status_base = PM805_INT_STATUS1,
 	.mask_base = PM805_INT_MASK1,
 	.ack_base = PM805_INT_STATUS1,
+	.mask_invert = 1,
 };
 
 static int __devinit device_805_init(struct pm80x_chip *chip)
-- 
1.7.0.4


             reply	other threads:[~2012-12-03  8:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03  8:11 Qing Xu [this message]
2012-12-12  6:28 ` Qing Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354522285-7563-1-git-send-email-qingx@marvell.com \
    --to=qingx@marvell.com \
    --cc=cxie4@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tianxf@marvell.com \
    --cc=zhouqiao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®