From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755157Ab2LCNyj (ORCPT ); Mon, 3 Dec 2012 08:54:39 -0500 Received: from mga11.intel.com ([192.55.52.93]:8866 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754823Ab2LCNyh (ORCPT ); Mon, 3 Dec 2012 08:54:37 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,206,1355126400"; d="scan'208";a="258228984" From: Alex Shi To: npiggin@kernel.dk, mingo@redhat.com, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH 01/10] sched: select_task_rq_fair clean up Date: Mon, 3 Dec 2012 21:54:05 +0800 Message-Id: <1354542848-29638-2-git-send-email-alex.shi@intel.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1354542848-29638-1-git-send-email-alex.shi@intel.com> References: <1354542848-29638-1-git-send-email-alex.shi@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is impossible to miss a task allowed cpu in a eligible group. And since find_idlest_group only return a different group which excludes old cpu, it's also imporissible to find a new cpu same as old cpu. Signed-off-by: Alex Shi --- kernel/sched/fair.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 59e072b..df99456 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3150,11 +3150,6 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags) } new_cpu = find_idlest_cpu(group, p, cpu); - if (new_cpu == -1 || new_cpu == cpu) { - /* Now try balancing at a lower domain level of cpu */ - sd = sd->child; - continue; - } /* Now try balancing at a lower domain level of new_cpu */ cpu = new_cpu; -- 1.7.5.4