From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756564Ab2LGP27 (ORCPT ); Fri, 7 Dec 2012 10:28:59 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:28605 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756545Ab2LGP26 (ORCPT ); Fri, 7 Dec 2012 10:28:58 -0500 X-Authority-Analysis: v=2.0 cv=EshQXFgA c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=0q0mCv_Vr9gA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=lrIq2vSOvhQA:10 a=JDrW0PuxuadbVPsa7BIA:9 a=PUjeQqilurYA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-ID: <1354894134.17101.44.camel@gandalf.local.home> Subject: Re: [PATCH] ARM: ftrace: Ensure code modifications are synchronised across all cpus From: Steven Rostedt To: "Jon Medhurst (Tixy)" Cc: linux-arm-kernel@lists.infradead.org, Russell King , Ingo Molnar , Frederic Weisbecker , Rabin Vincent , linux-kernel@vger.kernel.org Date: Fri, 07 Dec 2012 10:28:54 -0500 In-Reply-To: <1354892111.13000.50.camel@linaro1.home> References: <1354817466.30905.13.camel@linaro1.home> <1354821581.17101.17.camel@gandalf.local.home> <1354872138.3176.15.camel@computer5.home> <1354888985.17101.41.camel@gandalf.local.home> <1354892111.13000.50.camel@linaro1.home> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-12-07 at 14:55 +0000, Jon Medhurst (Tixy) wrote: > > > But also realize that function tracing is special :-) We have no cases > > like this. The instruction being replaced is a call to mcount. In fact, > > we replace it at boot with a nop. And this method only replaces that nop > > into a call to function tracer, or replaces the call to function tracer > > back to a nop. Always at the start of the function, and never involved > > with conditionals. This limitation that function tracing imposes on what > > we replace makes things a bit more sane in how we replace it. > > Then perhaps the method you suggest will work on ARM :-). However, that > is not something I personally propose to implement at this time. (I was > doing my good Samaritan act by trying to fix the crashes which another > team was getting when trying to use ftrace.) > I'm not NACKing your previous patch, I was just suggesting to bring ARM up to the future :-) I have no problems with the patch, but I just want to put it out there that there's better ways. It's part of the remove stomp_machine() crusade ;-) -- Steve