From: Chuansheng Liu <chuansheng.liu@intel.com>
To: tglx@linutronix.de, paul.mckenney@linaro.org,
srivatsa.bhat@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: [PATCH] smpboot: calling smpboot_register_percpu_thread is unsafe during one CPU being down
Date: Tue, 11 Dec 2012 22:17:47 +0800 [thread overview]
Message-ID: <1355235467.6184.10.camel@cliu38-desktop-build> (raw)
When one CPU is going down, and smpboot_register_percpu_thread is called,
there is the race issue below:
T1(CPUA): T2(CPUB):
_cpu_down() smpboot_register_percpu_thread()
smpboot_park_threads() ...
__stop_machine() __smpboot_create_thread(CPU_Dying)
[Currently, the being down CPU is online yet]
take_cpu_down() smpboot_unpark_thread(CPU_Dying)
__cpu_disable() ....
native_cpu_disable()
.... Here the new kthread will get running
based on the CPU_Dying
set_cpu_online(cpu, false)
....
cpu_notify(CPU_DYING)
After notified the CPU_DYING, the new created kthead for dying CPU will
be migrated to another CPU in migration_call().
Here we need use get_online_cpus()/put_online_cpus() when calling
function smpboot_register_percpu_thread().
Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
---
kernel/smpboot.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/smpboot.c b/kernel/smpboot.c
index d6c5fc0..3fe708a 100644
--- a/kernel/smpboot.c
+++ b/kernel/smpboot.c
@@ -266,6 +266,7 @@ int smpboot_register_percpu_thread(struct smp_hotplug_thread *plug_thread)
unsigned int cpu;
int ret = 0;
+ get_online_cpus();
mutex_lock(&smpboot_threads_lock);
for_each_online_cpu(cpu) {
ret = __smpboot_create_thread(plug_thread, cpu);
@@ -278,6 +279,7 @@ int smpboot_register_percpu_thread(struct smp_hotplug_thread *plug_thread)
list_add(&plug_thread->list, &hotplug_threads);
out:
mutex_unlock(&smpboot_threads_lock);
+ put_online_cpus();
return ret;
}
EXPORT_SYMBOL_GPL(smpboot_register_percpu_thread);
--
1.7.0.4
next reply other threads:[~2012-12-11 5:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 14:17 Chuansheng Liu [this message]
2012-12-11 6:30 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355235467.6184.10.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.mckenney@linaro.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®