From: Sasha Levin <sasha.levin@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Sasha Levin <sasha.levin@oracle.com>
Subject: [PATCH 15/15] tracing output: use new hashtable implementation
Date: Mon, 17 Dec 2012 10:01:35 -0500 [thread overview]
Message-ID: <1355756497-15834-15-git-send-email-sasha.levin@oracle.com> (raw)
In-Reply-To: <1355756497-15834-1-git-send-email-sasha.levin@oracle.com>
Switch tracing to use the new hashtable implementation. This reduces the
amount of generic unrelated code in the tracing module.
This patch depends on d9b482c ("hashtable: introduce a small and naive
hashtable") which was merged in v3.6.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
kernel/trace/trace_output.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 194d796..d102d26 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -8,15 +8,15 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/ftrace.h>
+#include <linux/hashtable.h>
#include "trace_output.h"
-/* must be a power of 2 */
-#define EVENT_HASHSIZE 128
+#define EVENT_HASH_BITS 7
DECLARE_RWSEM(trace_event_mutex);
-static struct hlist_head event_hash[EVENT_HASHSIZE] __read_mostly;
+static DEFINE_HASHTABLE(event_hash, EVENT_HASH_BITS);
static int next_event_type = __TRACE_LAST_TYPE + 1;
@@ -740,11 +740,8 @@ struct trace_event *ftrace_find_event(int type)
{
struct trace_event *event;
struct hlist_node *n;
- unsigned key;
- key = type & (EVENT_HASHSIZE - 1);
-
- hlist_for_each_entry(event, n, &event_hash[key], node) {
+ hash_for_each_possible(event_hash, event, n, node, type) {
if (event->type == type)
return event;
}
@@ -809,7 +806,6 @@ void trace_event_read_unlock(void)
*/
int register_ftrace_event(struct trace_event *event)
{
- unsigned key;
int ret = 0;
down_write(&trace_event_mutex);
@@ -861,9 +857,7 @@ int register_ftrace_event(struct trace_event *event)
if (event->funcs->binary == NULL)
event->funcs->binary = trace_nop_print;
- key = event->type & (EVENT_HASHSIZE - 1);
-
- hlist_add_head(&event->node, &event_hash[key]);
+ hash_add(event_hash, &event->node, event->type);
ret = event->type;
out:
@@ -878,7 +872,7 @@ EXPORT_SYMBOL_GPL(register_ftrace_event);
*/
int __unregister_ftrace_event(struct trace_event *event)
{
- hlist_del(&event->node);
+ hash_del(&event->node);
list_del(&event->list);
return 0;
}
--
1.8.0
prev parent reply other threads:[~2012-12-17 15:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 15:01 [PATCH 01/15] userns: " Sasha Levin
2012-12-17 15:01 ` [PATCH 02/15] mm,ksm: " Sasha Levin
2012-12-18 3:25 ` Hugh Dickins
2012-12-17 15:01 ` [PATCH 03/15] workqueue: " Sasha Levin
2012-12-18 17:24 ` Tejun Heo
2012-12-17 15:01 ` [PATCH 04/15] mm/huge_memory: " Sasha Levin
2012-12-19 22:26 ` David Rientjes
2012-12-20 2:25 ` Sasha Levin
2012-12-20 20:28 ` David Rientjes
2012-12-20 20:30 ` Sasha Levin
2012-12-17 15:01 ` [PATCH 05/15] tracepoint: " Sasha Levin
2012-12-17 15:48 ` Steven Rostedt
2012-12-17 15:01 ` [PATCH 06/15] net,9p: " Sasha Levin
2012-12-17 15:01 ` [PATCH 07/15] block,elevator: " Sasha Levin
2012-12-17 15:18 ` Jens Axboe
2012-12-17 15:01 ` [PATCH 08/15] SUNRPC/cache: " Sasha Levin
2012-12-17 15:01 ` [PATCH 09/15] dlm: " Sasha Levin
2012-12-17 15:01 ` [PATCH 10/15] net,l2tp: " Sasha Levin
2012-12-17 15:01 ` [PATCH 11/15] dm: " Sasha Levin
2013-01-11 18:49 ` Sasha Levin
2012-12-17 15:01 ` [PATCH 12/15] lockd: " Sasha Levin
2012-12-17 15:01 ` [PATCH 13/15] net,rds: " Sasha Levin
2012-12-17 15:01 ` [PATCH 14/15] openvswitch: " Sasha Levin
2012-12-17 15:01 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355756497-15834-15-git-send-email-sasha.levin@oracle.com \
--to=sasha.levin@oracle.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®