From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
spear-devel <spear-devel@list.st.com>,
linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH 2/2] dma: dw_dmac: clear suspend during termination
Date: Mon, 17 Dec 2012 17:26:57 +0200 [thread overview]
Message-ID: <1355758017.31620.110.camel@smile> (raw)
In-Reply-To: <CAKohpom-C-VYnyHHu8hVVpvDWrkLUAFVs9f9Qu+74XtiFVRZvg@mail.gmail.com>
On Mon, 2012-12-17 at 20:42 +0530, Viresh Kumar wrote:
> On 17 December 2012 19:37, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
> > Clear DWC_CFGL_CH_SUSP bit during termination if the channel
> > was paused.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Insufficient commit log :(
> You don't have to say here, what you are doing, but why you are doing it.
Fighting against bug. The workflow in our case is to a) pause the dma,
b) do something in the slave driver, c) terminate all transfers, d)
submit new transfer. But d) doesn't happen because the channel is still
paused.
> Please mention the reason here first, then repost the series after getting my
> comments
Okay.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-12-17 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 14:07 [PATCH 1/2] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume Andy Shevchenko
2012-12-17 14:07 ` [PATCH 2/2] dma: dw_dmac: clear suspend during termination Andy Shevchenko
2012-12-17 15:12 ` Viresh Kumar
2012-12-17 15:26 ` Andy Shevchenko [this message]
2012-12-17 16:12 ` [PATCH 1/2] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355758017.31620.110.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome