mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: Kurt Van Dijck <kurt.van.dijck@eia.be>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Bernd Krumboeck <b.krumboeck@gmail.com>,
	linux-kernel@vger.kernel.org,
	Bernd Krumboeck <krumboeck@universalnet.at>,
	Fabio Baltieri <fabio.baltieri@gmail.com>
Subject: [PATCH 10/10] can: usb_8dev: add LED trigger support
Date: Tue, 18 Dec 2012 18:51:04 +0100	[thread overview]
Message-ID: <1355853064-18144-11-git-send-email-fabio.baltieri@gmail.com> (raw)
In-Reply-To: <1355853064-18144-1-git-send-email-fabio.baltieri@gmail.com>

From: Bernd Krumboeck <b.krumboeck@gmail.com>

Add support for canbus activity led indicators on usb_8dev devices by
calling appropriate can_led functions.

These are only enabled when CONFIG_CAN_LEDS is Y, becomes no-op
otherwise.

Signed-off-by: Bernd Krumboeck <krumboeck@universalnet.at>
Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
---
 drivers/net/can/usb/usb_8dev.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c
index 660b4f87..b4bb1a6 100644
--- a/drivers/net/can/usb/usb_8dev.c
+++ b/drivers/net/can/usb/usb_8dev.c
@@ -33,6 +33,7 @@
 #include <linux/can.h>
 #include <linux/can/dev.h>
 #include <linux/can/error.h>
+#include <linux/can/led.h>
 
 /* driver constants */
 #define MAX_RX_URBS			10
@@ -504,6 +505,8 @@ static void usb_8dev_rx_can_msg(struct usb_8dev_priv *priv,
 
 		stats->rx_packets++;
 		stats->rx_bytes += cf->can_dlc;
+
+		can_led_event(priv->netdev, CAN_LED_EVENT_RX);
 	} else {
 		netdev_warn(priv->netdev, "frame type %d unknown",
 			 msg->type);
@@ -606,6 +609,8 @@ static void usb_8dev_write_bulk_callback(struct urb *urb)
 
 	can_get_echo_skb(netdev, context->echo_index);
 
+	can_led_event(netdev, CAN_LED_EVENT_TX);
+
 	/* Release context */
 	context->echo_index = MAX_TX_URBS;
 
@@ -830,6 +835,8 @@ static int usb_8dev_open(struct net_device *netdev)
 	if (err)
 		return err;
 
+	can_led_event(netdev, CAN_LED_EVENT_OPEN);
+
 	/* finally start device */
 	err = usb_8dev_start(priv);
 	if (err) {
@@ -882,6 +889,8 @@ static int usb_8dev_close(struct net_device *netdev)
 
 	close_candev(netdev);
 
+	can_led_event(netdev, CAN_LED_EVENT_STOP);
+
 	return err;
 }
 
@@ -990,6 +999,8 @@ static int usb_8dev_probe(struct usb_interface *intf,
 			 (version>>8) & 0xff, version & 0xff);
 	}
 
+	devm_can_led_init(netdev);
+
 	return 0;
 
 cleanup_cmd_msg_buffer:
-- 
1.7.12.1


  parent reply	other threads:[~2012-12-18 17:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 17:50 [PATCH v2 00/10] tx/rx " Fabio Baltieri
2012-12-18 17:50 ` [PATCH 01/10] can: add " Fabio Baltieri
2012-12-18 17:50 ` [PATCH 02/10] can: export a safe netdev_priv wrapper for candev Fabio Baltieri
2012-12-18 17:50 ` [PATCH 03/10] can: rename LED trigger name on netdev renames Fabio Baltieri
2012-12-18 17:50 ` [PATCH 04/10] can: flexcan: add LED trigger support Fabio Baltieri
2012-12-18 17:50 ` [PATCH 05/10] can: at91_can: " Fabio Baltieri
2012-12-18 17:51 ` [PATCH 06/10] can: ti_hecc: " Fabio Baltieri
2012-12-18 17:51 ` [PATCH 07/10] can: c_can: " Fabio Baltieri
2012-12-18 17:51 ` [PATCH 08/10] can: mcp251x: " Fabio Baltieri
2012-12-18 17:51 ` [PATCH 09/10] can: sja1000: " Fabio Baltieri
2012-12-18 17:51 ` Fabio Baltieri [this message]
2013-01-15 20:41 ` [PATCH v2 00/10] tx/rx " Marc Kleine-Budde
2013-01-22 21:39   ` Marc Kleine-Budde
2013-01-22 21:55   ` Marc Kleine-Budde
2013-01-22 22:53     ` Fabio Baltieri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355853064-18144-11-git-send-email-fabio.baltieri@gmail.com \
    --to=fabio.baltieri@gmail.com \
    --cc=b.krumboeck@gmail.com \
    --cc=krumboeck@universalnet.at \
    --cc=kurt.van.dijck@eia.be \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=socketcan@hartkopp.net \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®