mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Steve French <smfrench@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, Jeff Layton <jlayton@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Steve French <sfrench@samba.org>,
	linux-cifs@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: vfs trace points?: was: cifs: Do not enable debugging code by default
Date: Tue, 18 Dec 2012 10:10:04 -0800	[thread overview]
Message-ID: <1355854204.30366.11.camel@joe-AO722> (raw)
In-Reply-To: <CAH2r5mt622hpU=iC8BL1gvSD-fnjWnE=Qm+pph_AY5ob0zbejQ@mail.gmail.com>

On Tue, 2012-12-18 at 09:33 -0600, Steve French wrote:
> On Tue, Dec 18, 2012 at 9:19 AM, Borislav Petkov <bp@alien8.de> wrote:
> > On Tue, Dec 18, 2012 at 10:07:02AM -0500, Jeff Layton wrote:
> >> Yeah, not many do, but presumably they'll set it once and forget about
> >> it. Once someone straightens them out, they should rarely break.
> >>
> >> OTOH, the value of defaulting to "N" is pretty low here. Maybe it
> >> would just be best to just drop this patch and have the embedded folks
> >> turn this off on their own.
> >
> > Yeah, sure.
> 
> I am ok with disabling it for embedded, but probably easier to drop
> it.   The real benefit will come when someone familiar with dynamic
> trace points comes up with some good examples for file system(s) and
> the VFS so we can reduce our dependency on static tracing.

I'm fine with requiring embedded to turn this off
where appropriate.

It seems that keeping cifs KERN_DEBUG output for
normal kernels is pretty cost free.  120KB ain't much
these days.

I do think that Al Viro & Ted Ts'o should be pinged
about their vfs tracing thoughts. (cc'd)

MIT seems to bounce my emails, so maybe you could ask
Ted directly.



      reply	other threads:[~2012-12-18 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17  9:38 [PATCH] " Borislav Petkov
2012-12-17 15:30 ` Steve French
2012-12-18 12:13   ` Jeff Layton
2012-12-18 14:44     ` Borislav Petkov
2012-12-18 15:07       ` Jeff Layton
2012-12-18 15:19         ` Borislav Petkov
2012-12-18 15:33           ` Steve French
2012-12-18 18:10             ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355854204.30366.11.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=bp@alien8.de \
    --cc=jlayton@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    --cc=tytso@mit.edu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®