From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752340Ab2LTM0N (ORCPT ); Thu, 20 Dec 2012 07:26:13 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57186 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602Ab2LTM0D (ORCPT ); Thu, 20 Dec 2012 07:26:03 -0500 From: Borislav Petkov To: LKML Cc: Borislav Petkov , Jeff Garzik , linux-ide@vger.kernel.org Subject: [PATCH] libata: Shut up annoying native_sectors warning Date: Thu, 20 Dec 2012 13:25:55 +0100 Message-Id: <1356006355-6819-1-git-send-email-bp@alien8.de> X-Mailer: git-send-email 1.8.1.rc2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm getting this drivers/ata/libata-core.c: In function ‘ata_hpa_resize’: drivers/ata/libata-core.c:1397:3: warning: ‘native_sectors’ may be used uninitialized in this function [-Wmaybe-uninitialized] for a couple of kernel releases now with gcc (Debian 4.7.2-4) 4.7.2. And the warning is bogus because ata_read_native_max_address either returns a sensible max_sectors aka native_sectors through its second arg pointer or an error value which is properly handled in its caller ata_hpa_resize(). So shut up gcc already. Cc: Jeff Garzik Cc: linux-ide@vger.kernel.org Signed-off-by: Borislav Petkov --- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 9e8b99af400d..3860f6be8c19 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -1324,7 +1324,7 @@ static int ata_hpa_resize(struct ata_device *dev) int print_info = ehc->i.flags & ATA_EHI_PRINTINFO; bool unlock_hpa = ata_ignore_hpa || dev->flags & ATA_DFLAG_UNLOCK_HPA; u64 sectors = ata_id_n_sectors(dev->id); - u64 native_sectors; + u64 native_sectors = 0; int rc; /* do we need to do it? */ -- 1.8.1.rc2