From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589Ab2LVCDr (ORCPT ); Fri, 21 Dec 2012 21:03:47 -0500 Received: from mail-ia0-f178.google.com ([209.85.210.178]:36047 "EHLO mail-ia0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141Ab2LVB6E (ORCPT ); Fri, 21 Dec 2012 20:58:04 -0500 From: Tejun Heo To: linux-kernel@vger.kernel.org Cc: Tejun Heo , MyungJoo Ham , Kyungmin Park Subject: [PATCH 05/25] devfreq: don't use [delayed_]work_pending() Date: Fri, 21 Dec 2012 17:56:55 -0800 Message-Id: <1356141435-17340-6-git-send-email-tj@kernel.org> X-Mailer: git-send-email 1.8.0.2 In-Reply-To: <1356141435-17340-1-git-send-email-tj@kernel.org> References: <1356141435-17340-1-git-send-email-tj@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no need to test whether a (delayed) work item in pending before queueing, flushing or cancelling it. Most uses are unnecessary and quite a few of them are buggy. Remove unnecessary pending tests from devfreq. Only compile tested. Signed-off-by: Tejun Heo Cc: MyungJoo Ham Cc: Kyungmin Park --- Please let me know how this patch should be routed. I can take it through the workqueue tree if necessary. Thanks. drivers/devfreq/devfreq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 53766f3..fb4695e 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -291,8 +291,7 @@ void devfreq_monitor_resume(struct devfreq *devfreq) if (!devfreq->stop_polling) goto out; - if (!delayed_work_pending(&devfreq->work) && - devfreq->profile->polling_ms) + if (devfreq->profile->polling_ms) queue_delayed_work(devfreq_wq, &devfreq->work, msecs_to_jiffies(devfreq->profile->polling_ms)); devfreq->stop_polling = false; -- 1.8.0.2