From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Drunkard Zhang <gongfan193@gmail.com>
Cc: Xi Wang <xi.wang@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Jack Wang <jack_wang@usish.com>,
Xiangliang Yu <yuxiangl@marvell.com>,
linux-scsi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: mvsas regression since 3.5
Date: Sun, 23 Dec 2012 08:44:57 +0000 [thread overview]
Message-ID: <1356252297.15812.2.camel@dabdike.home> (raw)
In-Reply-To: <CAJiejCQXQWztiA8ksfRmxqx969FFpuL3DXH=EXmbOkYHE6VA5g@mail.gmail.com>
On Sun, 2012-12-23 at 16:26 +0800, Drunkard Zhang wrote:
> > Particularly, can you first change
> >
> > #define bit(n) ((u64)1 << n)
> >
> > in drivers/scsi/mvsas/mv_sas.h back to
> >
> > #define bit(n) ((u32)1 << n)
> >
> > and see if it works for you? Thanks.
> >
>
> Thanks for reply.
>
> This commit just applied in v3.8-rc1, so can't be it. I'm testing
> related commits too...
There are only three changes to mvsas between 3.5 and 3.7:
95ab000 [SCSI] mvsas: Fix oops when ata commond timeout.
cca8501 [SCSI] mvsas: remove unused variable in mvs_task_exec()
f0bf750 [SCSI] libsas: trim sas_task of slow path infrastructure
And of those, I can only see f0bf750 being significant, if you could
revert it?
After that, it's probably a bug introduced into libsas, which has a bit
more of a complicated history from 3.5 to 3.7:
8d8e7d1 [SCSI] libsas, ipr: cleanup ata_host flags initialization via ata_host_init
303694e [SCSI] libsas: suspend / resume support
2955b47 [SCSI] async: introduce 'async_domain' type
f0bf750 [SCSI] libsas: trim sas_task of slow path infrastructure
a494fd5 [SCSI] libsas: drop sata port multiplier infrastructure
b17caa1 [SCSI] libsas: fix sas_discover_devices return code handling
26f2f19 [SCSI] libsas: continue revalidation
b2311a2 [SCSI] libsas: sas_rediscover_dev did not look at the SMP exec status.
e7db822 [SCSI] libsas: use ->lldd_I_T_nexus_reset for ->eh_bus_reset_handler
9524c68 [SCSI] libsas: add sas_eh_abort_handler
5db45bd [SCSI] libsas: enforce eh strategy handlers only in eh context
36fed49 [SCSI] libsas: cleanup spurious calls to scsi_schedule_eh
e4a9c37 [SCSI] libata, libsas: introduce sched_eh and end_eh port ops
So I'd try a bisection rather than trying to revert individual commits
in there.
James
next prev parent reply other threads:[~2012-12-23 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 15:33 Drunkard Zhang
2012-12-23 7:17 ` Xi Wang
2012-12-23 8:26 ` Drunkard Zhang
2012-12-23 8:44 ` James Bottomley [this message]
2012-12-24 1:50 ` Jack Wang
2012-12-24 4:32 ` Drunkard Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356252297.15812.2.camel@dabdike.home \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.j.williams@intel.com \
--cc=gongfan193@gmail.com \
--cc=jack_wang@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=xi.wang@gmail.com \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®