mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: <a.zummo@towertech.it>
Cc: <akpm@linuxfoundation.org>, <broonie@opensource.wolfsonmicro.com>,
	<rtc-linux@googlegroups.com>, <linux-kernel@vger.kernel.org>,
	Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH 4/4] rtc: tps65910: set irq flag to IRQF_EARLY_RESUME during irq request
Date: Mon, 24 Dec 2012 15:21:27 +0530	[thread overview]
Message-ID: <1356342687-3432-5-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1356342687-3432-1-git-send-email-ldewangan@nvidia.com>

All interrupt get disabled during system suspend and enabled during
system resume. The enabling/disabling of interrupt happen in sequence
of interrupt registration with framework.

Therefore, in resume, the parent interrupt of this device enabled before
the RTC irq interrupt enabled. If RTC is enabled for alarm wake and if
system wake by alarm then there is interrupt pending for RTC. In resume,
the parent interrupt get enabled before the rtc interrupt and hence ISR
get served. In ISR, it founds that rtc interrupt is disabled and so it does
not call the rtc isr handler and hence it misses the interrupt.

Setting flag for early resume so that rtc interrupt get enabled before
parent interrupt  and so rtc interrupt get enabled when parent interrupt
handler check for interrupt of device and call the rtc handler if it is there.
This way it will not miss the interrupt.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 drivers/rtc/rtc-tps65910.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
index ff98e18..d2e1c08 100644
--- a/drivers/rtc/rtc-tps65910.c
+++ b/drivers/rtc/rtc-tps65910.c
@@ -267,7 +267,7 @@ static int __devinit tps65910_rtc_probe(struct platform_device *pdev)
 	}
 
 	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW,
+		tps65910_rtc_interrupt, IRQF_TRIGGER_LOW | IRQF_EARLY_RESUME,
 		dev_name(&pdev->dev), &pdev->dev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "IRQ is not free.\n");
-- 
1.7.1.1


      parent reply	other threads:[~2012-12-24  9:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-24  9:51 [PATCH 0/4] rtc: tps65910: cleanups and fixes for wake enable Laxman Dewangan
2012-12-24  9:51 ` [PATCH 1/4] rtc: tps65910: enable/disable wake in suspend/resume Laxman Dewangan
2012-12-24  9:51 ` [PATCH 2/4] rtc: tps65910: remove un-necessary irq stat save and restore Laxman Dewangan
2012-12-24  9:51 ` [PATCH 3/4] rtc: tps65910: use sleep_pm_ops macro for initialising suspend/resume callbacks Laxman Dewangan
2012-12-24  9:51 ` Laxman Dewangan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356342687-3432-5-git-send-email-ldewangan@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linuxfoundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®