From: Omar Ramirez Luna <omar.ramirez@copitl.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Chen Gang <gang.chen@asianux.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org,
Omar Ramirez Luna <omar.ramirez@copitl.com>
Subject: [PATCH] mfd: twl4030: TWL4030_CORE needs REGMAP and REGMAP_I2C
Date: Mon, 24 Dec 2012 07:12:30 -0600 [thread overview]
Message-ID: <1356354750-22969-1-git-send-email-omar.ramirez@copitl.com> (raw)
Selecting REGMAP_I2C defaults REGMAP to "y", no need to
explicitly select it.
This fixes:
- Because of REGMAP, a bunch of:
drivers/mfd/twl-core.c:221:29:
error: array type has incomplete element type
drivers/mfd/twl-core.c:224:3:
error: field name not in record or union initializer
drivers/mfd/twl-core.c:224:3:
error: (near initialization for 'twl4030_regmap_config')
- Because of REGMAP_I2C:
drivers/mfd/twl-core.c: In function 'twl_probe':
drivers/mfd/twl-core.c:1256:3: error: implicit declaration of function
'devm_regmap_init_i2c' [-Werror=implicit-function-declaration]
Reported-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@copitl.com>
---
drivers/mfd/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 1c0abd4..47ad4e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -292,6 +292,7 @@ config TWL4030_CORE
bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
depends on I2C=y && GENERIC_HARDIRQS
select IRQ_DOMAIN
+ select REGMAP_I2C
help
Say yes here if you have TWL4030 / TWL6030 family chip on your board.
This core driver provides register access and IRQ handling
--
1.7.4.4
reply other threads:[~2012-12-24 13:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356354750-22969-1-git-send-email-omar.ramirez@copitl.com \
--to=omar.ramirez@copitl.com \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®