From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Kyuho Choi <chlrbgh0@gmail.com>
Cc: subhashj@codeaurora.org, cang@codeaurora.org,
vivek.gautam@codeaurora.org, rnayak@codeaurora.org,
vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
Yaniv Gardi <ygardi@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] scsi: ufs: Allowing power mode change
Date: Fri, 23 Feb 2018 12:33:46 +0530 [thread overview]
Message-ID: <13563e4e-1b4d-8791-12ec-8fcb752f3b96@codeaurora.org> (raw)
In-Reply-To: <CAP2JTQK3jNrNvxz=aF9weuO1M38zBCCa8YJfz5tazXF61p257w@mail.gmail.com>
On 2/23/2018 10:40 AM, Kyuho Choi wrote:
> Hi Asutosh,
>
> I've simple question in below.
>
> On 2/21/18, Asutosh Das <asutoshd@codeaurora.org> wrote:
>> From: Yaniv Gardi <ygardi@codeaurora.org>
>>
>> Due to M-PHY issues, moving from HS to any other mode or gear or
>> even Hibern8 causes some un-predicted behavior of the device.
>> This patch fixes this issues.
>>
>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
>> ---
>> drivers/scsi/ufs/ufshcd.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 011c336..d74d529 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -4167,9 +4167,13 @@ static int ufshcd_link_startup(struct ufs_hba *hba)
>> goto out;
>> } while (ret && retries--);
>>
>> - if (ret)
>> + if (ret) {
>> /* failed to get the link up... retire */
>> goto out;
>> + } else {
>> + ufshcd_dme_set(hba, UIC_ARG_MIB(TX_LCC_ENABLE), 0);
>> + ufshcd_dme_set(hba, UIC_ARG_MIB(TX_LCC_ENABLE), 1);
>> + }
>>
>
> Every ufs host has same issue and affected?.
>
>> if (link_startup_again) {
>> link_startup_again = false;
>> --
>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
>> Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
>> Foundation Collaborative Project.
>>
>>
Hi Choi
Thanks for the review.
No - I can't say if every host has the same issue. However, I get your
point. It could be done with a quirk.
I'll fix this in v2 after collating all the comments from the rest of
the patches.
-asd
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-02-23 7:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1519120988.git.asutoshd@codeaurora.org>
2018-02-21 4:56 ` Asutosh Das
2018-02-23 5:10 ` Kyuho Choi
2018-02-23 7:03 ` Asutosh Das (asd) [this message]
2018-02-21 4:56 ` [PATCH 2/9] scsi: ufs: Add LCC quirk for host and device Asutosh Das
2018-02-21 4:56 ` [PATCH 3/9] scsi: ufs: fix exception event handling Asutosh Das
2018-02-21 4:56 ` [PATCH 4/9] scsi: ufshcd: fix possible unclocked register access Asutosh Das
2018-02-21 4:56 ` [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests Asutosh Das
2018-02-21 13:18 ` Stanislav Nijnikov
2018-02-23 2:31 ` Asutosh Das (asd)
2018-02-21 4:56 ` [PATCH 6/9] scsi: ufs-qcom: remove broken hci version quirk Asutosh Das
2018-02-21 4:56 ` [PATCH 7/9] scsi: ufs: make sure all interrupts are processed Asutosh Das
2018-02-21 4:56 ` [PATCH 8/9] scsi: ufs: fix irq return code Asutosh Das
2018-02-21 4:56 ` [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue Asutosh Das
2018-02-23 23:57 ` Miguel Ojeda
2018-02-26 3:55 ` Asutosh Das (asd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13563e4e-1b4d-8791-12ec-8fcb752f3b96@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=chlrbgh0@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rnayak@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome