From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linux Containers <containers@lists.linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk
Date: Wed, 26 Dec 2012 11:48:26 +0900 [thread overview]
Message-ID: <1356490106.16178.146.camel@kjgkr> (raw)
In-Reply-To: <87obhh63wz.fsf@xmission.com>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
2012-12-25 (화), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
>
> CC fs/f2fs/acl.o
> fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
> fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
>
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids. When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary. Remove the assignment so f2fs will build with user
> namespaces enabled.
>
> Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> Cc: Namjae Jeon <namjae.jeon@samsung.com>
> Cc: Amit Sahrawat <a.sahrawat@samsung.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-26 2:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 0:41 Eric W. Biederman
2012-12-26 2:48 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356490106.16178.146.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=a.sahrawat@samsung.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®