From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842Ab2L0VDg (ORCPT ); Thu, 27 Dec 2012 16:03:36 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:35886 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023Ab2L0VDc (ORCPT ); Thu, 27 Dec 2012 16:03:32 -0500 Subject: Re: [PATCH] forcedeth: Fix WARNINGS that result when DMA mapping is not checked From: Eric Dumazet To: Larry Finger Cc: linville@tuxdriver.com, davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <50DCB1D9.50906@lwfinger.net> References: <1356637327-4884-1-git-send-email-Larry.Finger@lwfinger.net> <1356638715.30414.1349.camel@edumazet-glaptop> <50DCB1D9.50906@lwfinger.net> Content-Type: text/plain; charset="UTF-8" Date: Thu, 27 Dec 2012 13:03:29 -0800 Message-ID: <1356642209.30414.1411.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-12-27 at 14:38 -0600, Larry Finger wrote: > On 12/27/2012 02:05 PM, Eric Dumazet wrote: > > On Thu, 2012-12-27 at 13:42 -0600, Larry Finger wrote: > >> + if (pci_dma_mapping_error(np->pci_dev, > >> + np->put_tx_ctx->dma)) > >> + return NETDEV_TX_BUSY; > > > > Really this is not going to work very well : caller will call this in a > > loop. > > Any suggestions on what value should be returned, or does the caller need to be > modified? NETDEV_TX_BUSY is really obsolete Documentation/networking/driver.txt In case of mapping error, I would drop the packet. (kfree_skb() it, increment a device tx_dropped counter, and return NETDEV_TX_OK)